Bug 2259267 - Review Request: golang-github-blackfireio-osinfo - Go OS Info library
Summary: Review Request: golang-github-blackfireio-osinfo - Go OS Info library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Alessandro Locati
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2259282
TreeView+ depends on / blocked
 
Reported: 2024-01-19 21:00 UTC by Arthur Bols
Modified: 2024-02-25 15:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-25 15:04:34 UTC
Type: ---
Embargoed:
me: fedora-review+


Attachments (Terms of Use)

Description Arthur Bols 2024-01-19 21:00:17 UTC
Spec URL: https://principis.fedorapeople.org/golang-github-blackfireio-osinfo.spec
SRPM URL: https://principis.fedorapeople.org/golang-github-blackfireio-osinfo-1.0.5-1.fc39.src.rpm
Description: Provides a cross-platform way to identify the hardware your go code is running on
Fedora Account System Username: principis

Comment 1 Fedora Review Service 2024-01-19 21:05:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6923228
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259267-golang-github-blackfireio-osinfo/fedora-rawhide-x86_64/06923228-golang-github-blackfireio-osinfo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Alessandro Locati 2024-02-25 14:42:27 UTC
go2rpm package, fedora-review is correct:

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-02-25 14:49:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-blackfireio-osinfo

Comment 4 Arthur Bols 2024-02-25 14:50:22 UTC
Thank you for the review Fabio!

Comment 5 Fedora Update System 2024-02-25 15:00:39 UTC
FEDORA-2024-31373de828 (golang-github-blackfireio-osinfo-1.0.5-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-31373de828

Comment 6 Fedora Update System 2024-02-25 15:04:34 UTC
FEDORA-2024-31373de828 (golang-github-blackfireio-osinfo-1.0.5-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.