Spec URL: https://principis.fedorapeople.org/golang-github-stoicperlman-fls.spec SRPM URL: https://principis.fedorapeople.org/golang-github-stoicperlman-fls-0-0.1.20240118gitf073b7a.fc39.src.rpm Description: Go File Line Seeker. Fedora Account System Username: principis
Copr build: https://copr.fedorainfracloud.org/coprs/build/6923263 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259274-golang-github-stoicperlman-fls/fedora-rawhide-x86_64/06923263-golang-github-stoicperlman-fls/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Recreated spec with go2rpm 1.11.0. Spec URL: https://principis.fedorapeople.org/golang-github-stoicperlman-fls.spec SRPM URL: https://principis.fedorapeople.org/golang-github-stoicperlman-fls-0-0.1.20240310gitf073b7a.fc39.src.rpm
Created attachment 2021000 [details] The .spec file difference from Copr build 6923263 to 7132016
Copr build: https://copr.fedorainfracloud.org/coprs/build/7132016 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259274-golang-github-stoicperlman-fls/fedora-rawhide-x86_64/07132016-golang-github-stoicperlman-fls/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance Thanks!
Sorry for missing the review and thanks for the effort. I'm abandoning this for now.