Spec URL: https://trix.fedorapeople.org/whisper-cpp.spec SRPM URL: https://trix.fedorapeople.org/whisper-cpp-1.5.4-1.fc40.src.rpm High-performance inference of OpenAI's Whisper automatic speech recognition (ASR) model: * Plain C/C++ implementation without dependencies * Apple Silicon first-class citizen - optimized via ARM NEON, Accelerate framework, Metal and Core ML * AVX intrinsics support for x86 architectures * VSX intrinsics support for POWER architectures * Mixed F16 / F32 precision * 4-bit and 5-bit integer quantization support * Zero memory allocations at runtime * Support for CPU-only inference * Efficient GPU support for NVIDIA * Partial OpenCL GPU support via CLBlast * OpenVINO Support * C-style API Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6926748 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259336-whisper-cpp/fedora-rawhide-x86_64/06926748-whisper-cpp/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I will take this review. It looks like you set your own fedora-review flag. Can you clear that please, so that I can set it under my username?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues ====== - The build passes architecture flags to gcc: -mavx -mavx2 -mfma -mf16c. Does this software use cpuid to ensure it doesn't execute instructions from those instruction sets if the CPU doesn't support them? If not, it will be necessary to prevent use of those instructions sets by passing these flags to cmake: -DWHISPER_NO_AVX -DWHISPER_NO_AVX2 -DWHISPER_NO_FMA -DWHISPER_NO_F16C ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "MIT No Attribution and/or The Unlicense", "*No copyright* GNU Free Documentation License", "Apache License 2.0". 391 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 36973 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: whisper-cpp-1.5.4-1.fc40.x86_64.rpm whisper-cpp-devel-1.5.4-1.fc40.x86_64.rpm whisper-cpp-debuginfo-1.5.4-1.fc40.x86_64.rpm whisper-cpp-debugsource-1.5.4-1.fc40.x86_64.rpm whisper-cpp-1.5.4-1.fc40.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa47i9vx0')] checks: 32, packages: 5 whisper-cpp.src: E: spelling-error ('intrinsics', '%description -l en_US intrinsics -> intrinsic, intrinsic s, extrinsic') whisper-cpp.x86_64: E: spelling-error ('intrinsics', '%description -l en_US intrinsics -> intrinsic, intrinsic s, extrinsic') whisper-cpp-devel.x86_64: E: spelling-error ('intrinsics', '%description -l en_US intrinsics -> intrinsic, intrinsic s, extrinsic') whisper-cpp.x86_64: W: no-documentation ========== 5 packages and 0 specfiles checked; 3 errors, 1 warnings, 29 filtered, 3 badness; has taken 0.5 s =========== Rpmlint (debuginfo) ------------------- Checking: whisper-cpp-debuginfo-1.5.4-1.fc40.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpld0mq887')] checks: 32, packages: 1 =========== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s =========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 whisper-cpp-devel.x86_64: E: spelling-error ('intrinsics', '%description -l en_US intrinsics -> intrinsic, intrinsic s, extrinsic') whisper-cpp.x86_64: E: spelling-error ('intrinsics', '%description -l en_US intrinsics -> intrinsic, intrinsic s, extrinsic') whisper-cpp.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 2 errors, 1 warnings, 25 filtered, 2 badness; has taken 0.4 s Source checksums ---------------- https://github.com/ggerganov/whisper.cpp/archive/refs/tags/v1.5.4.tar.gz#/whisper.cpp-1.5.4.tar.gz : CHECKSUM(SHA256) this package : 06eed84de310fdf5408527e41e863ac3b80b8603576ba0521177464b1b341a3a CHECKSUM(SHA256) upstream package : 06eed84de310fdf5408527e41e863ac3b80b8603576ba0521177464b1b341a3a Requires -------- whisper-cpp (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) whisper-cpp-devel (rpmlib, GLIBC filtered): libwhisper.so.1.5.4()(64bit) whisper-cpp(x86-64) whisper-cpp-debuginfo (rpmlib, GLIBC filtered): whisper-cpp-debugsource (rpmlib, GLIBC filtered): Provides -------- whisper-cpp: libwhisper.so.1.5.4()(64bit) whisper-cpp whisper-cpp(x86-64) whisper-cpp-devel: whisper-cpp-devel whisper-cpp-devel(x86-64) whisper-cpp-debuginfo: debuginfo(build-id) libwhisper.so.1.5.4-1.5.4-1.fc40.x86_64.debug()(64bit) whisper-cpp-debuginfo whisper-cpp-debuginfo(x86-64) whisper-cpp-debugsource: whisper-cpp-debugsource whisper-cpp-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2259336 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: PHP, Perl, Java, Ocaml, Python, Ruby, R, Haskell, fonts, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://trix.fedorapeople.org/whisper-cpp.spec SRPM URL: https://trix.fedorapeople.org/whisper-cpp-1.5.4-1.fc40.src.rpm For the more generic cpu options requested. changed to autorelease, autochangelog because that is what in other packages I work on use.
Created attachment 2015247 [details] The .spec file difference from Copr build 6926748 to 6987279
Copr build: https://copr.fedorainfracloud.org/coprs/build/6987279 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259336-whisper-cpp/fedora-rawhide-x86_64/06987279-whisper-cpp/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
That looks good. This package is APPROVED.