Spec URL: https://blinxen.fedorapeople.org/rust-sanitize-filename/rust-sanitize-filename.spec SRPM URL: https://blinxen.fedorapeople.org/rust-sanitize-filename/rust-sanitize-filename-0.5.0-1.fc40.src.rpm Description: A simple filename sanitizer, based on Node's sanitize-filename. Fedora Account System Username: blinxen
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=112108179
Copr build: https://copr.fedorainfracloud.org/coprs/build/6937227 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259417-rust-sanitize-filename/srpm-builds/06937227/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There's some minor issues: - Looks like the PR to ship the license file is merged upstream, can you include a link to the upstream commit? - Please don't reference file blobs from the "master" branch, instead use a specific commit. References to branches are not stable over time. - Use `%license %{crate_instdir}/LICENSE` instead of `%license LICENSE` - otherwise the file will get installed twice (once to `%crate_instdir`, once to `/usr/share/licenses/%{name}/LICENSE`). - Use `-p` flag for copying the LICENSE file to the build directory to preserve the timestamp. There's also a typo in the comment that you added above the patch (s/interessted/interested/).
There's also this issue: https://github.com/kardeiz/sanitize-filename/issues/4 You might want to chmod -x all affected files.
Fixed all issues, thanks for the review!! Links to the updated files: Spec URL: https://blinxen.fedorapeople.org/rust-sanitize-filename/rust-sanitize-filename.spec SRPM URL: https://blinxen.fedorapeople.org/rust-sanitize-filename/rust-sanitize-filename-0.5.0-1.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6965145 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259417-rust-sanitize-filename/fedora-rawhide-x86_64/06965145-rust-sanitize-filename/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks, looks good to me now! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files (manually included from upstream, PR submitted to include it) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sanitize-filename
FEDORA-2024-be51984551 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-be51984551
FEDORA-2024-be51984551 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.