Fedora Merge Review: jpackage-utils http://cvs.fedora.redhat.com/viewcvs/devel/jpackage-utils/ Initial Owner: fitzsim
rpmlint: Change Group tag to Applications/System, Utilities is not valid. Change license, JPackage License is invalid. I think BSD is closest. jpackage-utils.noarch: W: conffile-without-noreplace-flag /etc/java/jpackage-release A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here I can't find the tarball on the upstream site, so I can't tell you what the Source0 tag should be changed to, but it must include a URL. The %description is a little on the large side, and sort of blind-sided me when I rpm -qi jpackage-utils. Not a blocker, just a suggestion. Otherwise, looks great.
Any updates?
Adding current owner. . .
Reviewed current SRPM from rawhide. All the above still apply, except that the license tag has been fixed.
Ping?
Tested current rawhide version, same as #4.
None of the standard groups apply to this package. And it is not a system application, it is a collection of utility scripts only. Fedora policy allows rpmlint warnings about groups if none of the standard ones apply. License now says BSD in rawhide. /etc/java/jpackage-release should not be noreplace. Even if someone manually changes it for whatever reason, it should be overwritten when a new version is installed. /etc/fedora-release is the same way, %config without the noreplace. As for the description -- there is no README in the upstream tarball, which is why it is so long I believe. I'll move it to a readme and point to it from the description. Thanks for reviewing this. With the above description change, is it okay to close this issue?
File the above as rpmlint exceptions and we're good.
Great! New build is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1268274 The rpmlint says: jpackage-utils.src: W: non-standard-group Utilities jpackage-utils.noarch: W: non-standard-group Utilities The above 2 are acceptable because this package is a collection of utilities only, and there is no utility specific group in the grouplist that rpmlint searches. jpackage-utils.noarch: W: conffile-without-noreplace-flag /etc/java/jpackage-release The above is acceptable because even if the user changes the files, we want it to be overwritten when a newer version is installed - just as with the fedora-release file.
Great, APPROVED. Thanks!