Bug 225950 - Merge Review: jpackage-utils
Merge Review: jpackage-utils
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Gwyn Ciesla
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 14:13 EST by Nobody's working on this, feel free to take it
Modified: 2009-04-01 08:40 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-03-31 14:02:46 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
limburgher: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:13:22 EST
Fedora Merge Review: jpackage-utils

Initial Owner: fitzsim@redhat.com
Comment 1 Gwyn Ciesla 2008-02-04 13:04:02 EST

Change Group tag to Applications/System, Utilities is not valid.

Change license, JPackage License is invalid. I think BSD is closest.

jpackage-utils.noarch: W: conffile-without-noreplace-flag /etc/java/jpackage-release
A configuration file is stored in your package without the noreplace flag.
A way to resolve this is to put the following in your SPEC file:

%config(noreplace) /etc/your_config_file_here

I can't find the tarball on the upstream site, so I can't tell you what the
Source0 tag should be changed to, but it must include a URL.

The %description is a little on the large side, and sort of blind-sided me when
I rpm -qi jpackage-utils.  Not a blocker, just a suggestion.

Otherwise, looks great.
Comment 2 Gwyn Ciesla 2008-05-16 11:05:09 EDT
Any updates?
Comment 3 Gwyn Ciesla 2008-07-25 09:59:00 EDT
Adding current owner. . .
Comment 4 Gwyn Ciesla 2008-09-09 12:00:49 EDT
Reviewed current SRPM from rawhide.

All the above still apply, except that the license tag has been fixed.
Comment 5 Gwyn Ciesla 2008-12-09 15:31:44 EST
Comment 6 Gwyn Ciesla 2009-03-31 11:14:38 EDT
Tested current rawhide version, same as #4.
Comment 7 Deepak Bhole 2009-03-31 13:20:20 EDT
None of the standard groups apply to this package. And it is not a system application, it is a collection of utility scripts only. Fedora policy allows rpmlint warnings about groups if none of the standard ones apply.

License now says BSD in rawhide.

/etc/java/jpackage-release should not be noreplace. Even if someone manually changes it for whatever reason, it should be overwritten when a new version is installed. /etc/fedora-release is the same way, %config without the noreplace.

As for the description -- there is no README in the upstream tarball, which is why it is so long I believe. I'll move it to a readme and point to it from the description.

Thanks for reviewing this. With the above description change, is it okay to close this issue?
Comment 8 Gwyn Ciesla 2009-03-31 13:37:13 EDT
File the above as rpmlint exceptions and we're good.
Comment 9 Deepak Bhole 2009-03-31 14:02:46 EDT
Great! New build is here:

The rpmlint says:
jpackage-utils.src: W: non-standard-group Utilities
jpackage-utils.noarch: W: non-standard-group Utilities

The above 2 are acceptable because this package is a collection of utilities only, and there is no utility specific group in the grouplist that rpmlint searches.

jpackage-utils.noarch: W: conffile-without-noreplace-flag /etc/java/jpackage-release

The above is acceptable because even if the user changes the files, we want it to be overwritten when a newer version is installed - just as with the fedora-release file.
Comment 10 Gwyn Ciesla 2009-04-01 08:40:32 EDT
Great, APPROVED. Thanks!

Note You need to log in before you can comment on or make changes to this bug.