Spec URL: https://bugant.github.io/fedora/python-hiredis/python-hiredis.spec SRPM URL: https://bugant.github.io/fedora/python-hiredis/python-hiredis-2.2.3-1.fc39.src.rpm Description: Python extension that wraps protocol parsing code in hiredis. It primarily speeds up parsing of multi bulk replies. Fedora Account System Username:
Copr build: https://copr.fedorainfracloud.org/coprs/build/6940560 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259673-python-hiredis/fedora-rawhide-x86_64/06940560-python-hiredis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=112177104
This will supersede https://bugzilla.redhat.com/show_bug.cgi?id=2182814
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Please fix these 3 items: [!] Pacakge is missing: BuildArch: noarch [!] Latest package is not packaged (2.2.3 vs 2.3.2) [!]: Spec file according to URL is NOT the same as in SRPM. ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License". 29 files have unknown license. Detailed output of licensecheck in /home/paul/2259673-python-hiredis/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5478 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-hiredis [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python3-hiredis-2.2.3-1.fc40.x86_64.rpm python-hiredis-debugsource-2.2.3-1.fc40.x86_64.rpm python-hiredis-2.2.3-1.fc40.src.rpm ====================================== rpmlint session starts ====================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpujrt8p29')] checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 11 filtered, 0 badness; has taken 0.3 s = Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.2 s Unversioned so-files -------------------- python3-hiredis: /usr/lib64/python3.12/site-packages/hiredis/hiredis.cpython-312-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/redis/hiredis-py/archive/refs/tags/v2.2.3.tar.gz : CHECKSUM(SHA256) this package : a4be3ada0b833773b9f613c08d636e64b192922950db03118d2a5f12e8f03630 CHECKSUM(SHA256) upstream package : a4be3ada0b833773b9f613c08d636e64b192922950db03118d2a5f12e8f03630 Requires -------- python3-hiredis (rpmlib, GLIBC filtered): libc.so.6()(64bit) libhiredis.so.1.0.0()(64bit) python(abi) rtld(GNU_HASH) python-hiredis-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-hiredis: python-hiredis python3-hiredis python3-hiredis(x86-64) python3.12-hiredis python3.12dist(hiredis) python3dist(hiredis) python-hiredis-debugsource: python-hiredis-debugsource python-hiredis-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/paul/2259673-python-hiredis/srpm/python-hiredis.spec 2024-01-29 12:57:01.679672252 -0500 +++ /home/paul/2259673-python-hiredis/srpm-unpacked/python-hiredis.spec 2024-01-21 19:00:00.000000000 -0500 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.8) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + Name: python-hiredis Version: 2.2.3 @@ -62,3 +72,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Mon Jan 22 2024 John Doe <packager> - 2.2.3-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2259673 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic, C/C++ Disabled plugins: fonts, SugarActivity, Ocaml, PHP, Java, Haskell, Perl, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks Paul for the initial review. I addressed your comment and generated the new spec and src.rpm files. Note that I did not add "BuildArch: noarch" as the python library includes a module built from C code. Spec URL: https://bugant.github.io/fedora/python-hiredis/python-hiredis.spec SRPM URL: https://bugant.github.io/fedora/python-hiredis/python-hiredis-2.3.2-1.fc39.src.rpm
Created attachment 2014066 [details] The .spec file difference from Copr build 6940560 to 6974152
Copr build: https://copr.fedorainfracloud.org/coprs/build/6974152 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259673-python-hiredis/fedora-rawhide-x86_64/06974152-python-hiredis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fedora Account System Username: bugant
Ah yes I totally missed the .so file there in the review. My bad. It's a bit sad the .so is unversioned, but thats okay as it is not in the linker path. Package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-hiredis
Looks like the tarball was accidentally committed into the git repo. This will need releng help to fix.
Thanks Neal! I have now removed the tarball from the git repo. There is also this bug reported to releng: https://pagure.io/releng/issue/11933.