Fedora Merge Review: libcap http://cvs.fedora.redhat.com/viewcvs/devel/libcap/ Initial Owner: karsten
libcap-1.10-28 has some common review issues fixed
can't see license file installed. cp commands in SPEC should be used as "cp -p"
ping?
diff -r1.27 libcap.spec 3c3 < Release: 30 --- > Release: 31 65c65 < cp %{SOURCE1} doc/ --- > cp -p %{SOURCE1} doc/ 76c76 < %doc doc/capability.notes doc/capfaq-0.2.txt --- > %doc doc/capability.notes doc/capfaq-0.2.txt License
SHOULD: 1)Though not mandatory you can add disttag. 2)Remove following Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig 3) Good to have defattr used as now %defattr(-,root,root,-) 4) Correct changelog version. Sorry that I should I asked this previously before you built new release. Can you please do that again. Once above issues fixed in CVS. This package will be approved.
- I've added disttag - Why should I remove the requirements ? The package runs ldconfig in post and postun and needs to require them. Or is there any new guideline that I'm not aware of ? If so, can you give me a pointer to it ? - defattr changed to -,root,root,- new package is libcap-1.10-32.fc9
(In reply to comment #6) > - I've added disttag > - Why should I remove the requirements ? The package runs ldconfig in post and > postun and needs to require them. Or is there any new guideline that I'm not > aware of ? If so, can you give me a pointer to it ? > - defattr changed to -,root,root,- > > new package is libcap-1.10-32.fc9 Thanks. I saw http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-d0dbcb7eec27622a21df280009c5b089b02f5bef requirements are not mentioned there and even newer packages that got reviewed are not using that syntax.
You're right, the '%post -p' syntax will get parsed by find-requires and it isn't necessary to add that requirement manually (although it doesn't do any harm either)
(In reply to comment #8) > You're right, the '%post -p' syntax will get parsed by find-requires and it > isn't necessary to add that requirement manually (although it doesn't do any > harm either) Ok. But I still want you to remove it next time you build this package. APPROVED.
rebuilding such small packages isn't a problem. Fixed in libcap-1.10-33.fc9
Thanks. APPROVED.