Bug 225992 - Merge Review: libcap
Merge Review: libcap
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks: F9MergeReviewTarget
  Show dependency treegraph
 
Reported: 2007-01-31 14:19 EST by Nobody's working on this, feel free to take it
Modified: 2008-01-16 05:02 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-16 04:30:05 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
panemade: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:19:38 EST
Fedora Merge Review: libcap

http://cvs.fedora.redhat.com/viewcvs/devel/libcap/
Initial Owner: karsten@redhat.com
Comment 1 Karsten Hopp 2007-02-21 09:43:38 EST
libcap-1.10-28 has some common review issues fixed
Comment 2 Parag AN(पराग) 2007-12-07 00:07:05 EST
can't see license file installed.
cp commands in SPEC should be used as "cp -p"
Comment 3 Parag AN(पराग) 2008-01-11 07:20:14 EST
ping?
Comment 4 Karsten Hopp 2008-01-14 07:25:30 EST
diff -r1.27 libcap.spec
3c3
< Release: 30
---
> Release: 31
65c65
< cp %{SOURCE1} doc/
---
> cp -p %{SOURCE1} doc/
76c76
< %doc doc/capability.notes  doc/capfaq-0.2.txt
---
> %doc doc/capability.notes  doc/capfaq-0.2.txt License
Comment 5 Parag AN(पराग) 2008-01-14 22:27:15 EST
SHOULD:
   1)Though not mandatory you can add disttag.
   2)Remove following
   Requires(post):   /sbin/ldconfig
   Requires(postun): /sbin/ldconfig
   3) Good to have defattr used as now
    %defattr(-,root,root,-)
   4) Correct changelog version.

Sorry that I should I asked this previously before you built new release. Can
you please do that again.

Once above issues fixed in CVS. This package will be approved.


    
Comment 6 Karsten Hopp 2008-01-15 04:42:27 EST
- I've added disttag
- Why should I remove the requirements ? The package runs ldconfig in post and
postun and needs to require them. Or is there any new guideline that I'm not
aware of ? If so, can you give me a pointer to it ?
- defattr changed to -,root,root,-

new package is libcap-1.10-32.fc9
Comment 7 Parag AN(पराग) 2008-01-15 04:49:42 EST
(In reply to comment #6)
> - I've added disttag
> - Why should I remove the requirements ? The package runs ldconfig in post and
> postun and needs to require them. Or is there any new guideline that I'm not
> aware of ? If so, can you give me a pointer to it ?
> - defattr changed to -,root,root,-
> 
> new package is libcap-1.10-32.fc9

Thanks.
I saw
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-d0dbcb7eec27622a21df280009c5b089b02f5bef
requirements are not mentioned there and even newer packages that got reviewed
are not using that syntax.
Comment 8 Karsten Hopp 2008-01-15 05:11:45 EST
You're right, the '%post -p' syntax will get parsed by find-requires and it
isn't necessary to add that requirement manually (although it doesn't do any
harm either)
Comment 9 Parag AN(पराग) 2008-01-15 23:03:36 EST
(In reply to comment #8)
> You're right, the '%post -p' syntax will get parsed by find-requires and it
> isn't necessary to add that requirement manually (although it doesn't do any
> harm either)

Ok. But I still want you to remove it next time you build this package.

APPROVED.
Comment 10 Karsten Hopp 2008-01-16 04:30:05 EST
rebuilding such small packages isn't a problem. Fixed in libcap-1.10-33.fc9
Comment 11 Parag AN(पराग) 2008-01-16 05:02:39 EST
Thanks. 
APPROVED.

Note You need to log in before you can comment on or make changes to this bug.