Fedora Merge Review: libfontenc http://cvs.fedora.redhat.com/viewcvs/devel/libfontenc/ Initial Owner: sandmann
rpmlint gave libfontenc.src: W: spelling-error Summary(en_US) runtime -> run time, run-time, runtish libfontenc.src: W: name-repeated-in-summary C libfontenc libfontenc.src: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish libfontenc.src:30: W: unversioned-explicit-obsoletes XFree86-devel libfontenc.src:30: W: unversioned-explicit-obsoletes xorg-x11-devel libfontenc.src: W: invalid-url Source0: ftp://ftp.x.org/pub/individual/lib/libfontenc-1.0.5.tar.bz2 <urlopen error ftp error: timed out> libfontenc.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, runtish libfontenc.x86_64: W: name-repeated-in-summary C libfontenc libfontenc.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish libfontenc.x86_64: E: zero-length /usr/share/doc/libfontenc-1.0.5/AUTHORS libfontenc-devel.x86_64: W: obsolete-not-provided XFree86-devel libfontenc-devel.x86_64: W: obsolete-not-provided xorg-x11-devel libfontenc-devel.x86_64: W: no-documentation Suggestions: 1)As this review is currently for F15, following should be implemented in spec a) buildroot should be removed b) %clean not needed c) cleaning of buildroot at start of %install also not needed 2) AUTHORS file should be removed as its zero-length.
Created attachment 443407 [details] merge-review cleanup patch
Maintainer please commit above patch or approve me to commit it.
ssp and ajax have previously asked me to just go ahead and deal with simple merge review cleanups for them. I committed your patch to master, but did not build.
To make myself happy, I have built above changes to make sure some other spec commit will not overwrite it. APPROVED libfontenc-1.0.5-3.fc15 and Closing this review.