spec: https://download.copr.fedorainfracloud.org/results/fed500/eql5/fedora-rawhide-x86_64/06946928-eql5/eql5.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/eql5/fedora-rawhide-x86_64/06946928-eql5/eql5-0%5E28022022.440ac762-1.fc40.src.rpm description: Build desktop applications using Common Lisp and Qt. fas: fed500 koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=112270872 Comment: Header files are from source code for examples included as documentation Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6947068 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260121-eql5/fedora-rawhide-x86_64/06947068-eql5/fedora-review/review.txt Found issues: - eql5-examples : /usr/share/eql5/examples/M-modules/web-kit-engine/lib/_invokables.h eql5-examples : /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.h eql5-examples : /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/_invokables.h eql5-examples : /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/webkit_bridge.h eql5-examples : /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/_invokables.h eql5-examples : /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.h eql5-examples : /usr/share/eql5/examples/M-modules/webkit/lib/_invokables.h eql5-examples : /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.h eql5-examples : /usr/share/eql5/examples/X-extras/move-blocks/cpp/lib.h eql5-examples : /usr/share/eql5/examples/X-extras/palindrome/exe/main.h eql5-examples : /usr/share/eql5/examples/X-extras/qimage/cpp/lib.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I will take this review. I maintain the ecl package, but mostly due to inertia. I used to maintain it because sagemath needed it, but the sagemath package has been retired and I don't use ecl myself. If you would like the ecl package, I am happy to give it to you.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/eql5/examples/7-Sokoban/3rd- party/COPYING See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files The text above was generated by fedora-review. It is misleading. The problem is that there are two %license macros for a file named COPYING: %license %{_datadir}/eql5/examples/7-Sokoban/3rd-party/COPYING %license %{_datadir}/eql5/examples/M-modules/quick/sokoban/lisp/3rd-party/COPYING The two COPYING files are identical, so remove one from %license. - The License field for the examples subpackages has a lowercase "and". Change that to uppercase "AND". - According to examples/M-modules/quick/Tic-Tac-Toe/COPYING.txt, the license for the Tic-Tac-Toe module is BSD-3-Clause. Add that to the License field for the examples subpackage. - Does LICENSE-2-MAKE-QIMAGE.txt apply to examples/X-extras/qimage? I'm unclear on that. If it does, then BSD-2-Clause will need to be added to the examples License field as well. - src/lisp/COPYING-ECL-READLINE says that the readline interface is LGPL-2.0-only, but the header of lib/ecl-readline.lisp says that the file is GPL-2.0-or-later. Do you know what is going on here? - It is not clear to me that "BSD with no advertisement clause" is the same as 0BSD. Several other BSD variants do not have advertisement clauses, such as BSD-1-Clause and BSD-2-Clause. Has upstream stated somewhere that this means 0BSD specifically? - I think the 28022022 part of Version should be reversed, so the year is first. With this scheme, if upstream released on March 1, then the new version would be 01032022, which is smaller than 28022022. Make that 20220228 instead. - Note the EXTRA item "Large data in /usr/share should live in a noarch subpackage if package is arched" below. Is there some way to break the noarch data out into a separate subpackage? - Note the zero-length file warnings from rpmlint below. Do we need to package those files? - Also note the files-duplicate rpmlint warnings below. Is there some way to avoid the duplication? ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "BSD 2-Clause License", "Unknown or generated", "GNU General Public License", "GNU Library General Public License, Version 2.0", "BSD 3-Clause License". 514 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8767 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1495040 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: eql5-0^28022022.440ac762-1.fc40.x86_64.rpm eql5-devel-0^28022022.440ac762-1.fc40.x86_64.rpm eql5-doc-0^28022022.440ac762-1.fc40.noarch.rpm eql5-examples-0^28022022.440ac762-1.fc40.x86_64.rpm eql5-debuginfo-0^28022022.440ac762-1.fc40.x86_64.rpm eql5-debugsource-0^28022022.440ac762-1.fc40.x86_64.rpm eql5-0^28022022.440ac762-1.fc40.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp39q4jwt8')] checks: 32, packages: 7 eql5-examples.x86_64: E: zero-length /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.cpp eql5-examples.x86_64: E: zero-length /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/webkit_bridge.cpp eql5-examples.x86_64: E: zero-length /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.cpp eql5-examples.x86_64: E: zero-length /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.cpp eql5.x86_64: W: no-manual-page-for-binary eql5 eql5-devel.x86_64: W: no-documentation eql5-examples.x86_64: W: no-documentation eql5-examples.x86_64: E: no-binary eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/lisp/3rd-party/CONTRIBUTORS /usr/share/eql5/examples/7-Sokoban/3rd-party/CONTRIBUTORS eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/lisp/3rd-party/COPYING /usr/share/eql5/examples/7-Sokoban/3rd-party/COPYING eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/lisp/3rd-party/levels.lisp /usr/share/eql5/examples/7-Sokoban/3rd-party/levels.lisp eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/goal.png /usr/share/eql5/examples/7-Sokoban/pics/goal.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/object.png /usr/share/eql5/examples/7-Sokoban/pics/object.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/object2.png /usr/share/eql5/examples/7-Sokoban/pics/object2.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/player2.png /usr/share/eql5/examples/7-Sokoban/pics/player.png:/usr/share/eql5/examples/7-Sokoban/pics/player2.png:/usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/player.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/wall.png /usr/share/eql5/examples/7-Sokoban/pics/wall.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/multimedia/video-widget/ui/designer/README.txt /usr/share/eql5/examples/M-modules/multimedia/video-graphics-item/ui/designer/README.txt eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/table-view/properties.lisp /usr/share/eql5/examples/M-modules/quick/Tic-Tac-Toe/properties.lisp:/usr/share/eql5/examples/M-modules/quick/item-model/properties.lisp:/usr/share/eql5/examples/M-modules/quick/painted-item/properties.lisp:/usr/share/eql5/examples/M-modules/quick/palindrome-2/properties.lisp:/usr/share/eql5/examples/M-modules/quick/qml-lisp/properties.lisp:(and 1 more) eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/definitions.lisp /usr/share/eql5/examples/M-modules/quick/palindrome-1/definitions.lisp eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml-file.lisp /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml-file.lisp eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/A.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/A.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/E.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/E.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/N.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/N.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/O.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/O.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/P.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/P.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/R.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/R.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/S.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/S.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/T.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/T.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/webkit/README-GLUE-CODE.txt /usr/share/eql5/examples/M-modules/web-kit-engine/README-GLUE-CODE.txt:/usr/share/eql5/examples/M-modules/webkit/Examples-Browser/README-GLUE-CODE.txt eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.h /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.h:/usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.h eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.pro /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.pro eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.pro /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/webkit_bridge.pro eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/9-simple-lisp-editor/exe/main.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/9-simple-lisp-editor/send/send.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/web-kit-engine/lib/_invokables.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/_invokables.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/webkit_bridge.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/webkit_bridge.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/_invokables.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/lib/_invokables.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/move-blocks/cpp/lib.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/move-blocks/cpp/lib.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/palindrome/exe/main.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/palindrome/exe/main.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/qimage/cpp/lib.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/qimage/cpp/lib.h ========== 7 packages and 0 specfiles checked; 5 errors, 47 warnings, 56 filtered, 5 badness; has taken 1.7 s ========== Rpmlint (debuginfo) ------------------- Checking: eql5-debuginfo-0^28022022.440ac762-1.fc40.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjnfnv97m')] checks: 32, packages: 1 ========== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 26 filtered, 0 badness; has taken 0.6 s =========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 eql5-examples.x86_64: E: zero-length /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.cpp eql5-examples.x86_64: E: zero-length /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/webkit_bridge.cpp eql5-examples.x86_64: E: zero-length /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.cpp eql5-examples.x86_64: E: zero-length /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.cpp eql5.x86_64: W: no-manual-page-for-binary eql5 eql5-devel.x86_64: W: no-documentation eql5-examples.x86_64: W: no-documentation eql5-examples.x86_64: E: no-binary eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/lisp/3rd-party/CONTRIBUTORS /usr/share/eql5/examples/7-Sokoban/3rd-party/CONTRIBUTORS eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/lisp/3rd-party/COPYING /usr/share/eql5/examples/7-Sokoban/3rd-party/COPYING eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/lisp/3rd-party/levels.lisp /usr/share/eql5/examples/7-Sokoban/3rd-party/levels.lisp eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/goal.png /usr/share/eql5/examples/7-Sokoban/pics/goal.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/object.png /usr/share/eql5/examples/7-Sokoban/pics/object.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/object2.png /usr/share/eql5/examples/7-Sokoban/pics/object2.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/player2.png /usr/share/eql5/examples/7-Sokoban/pics/player.png:/usr/share/eql5/examples/7-Sokoban/pics/player2.png:/usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/player.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/sokoban/qml/img/wall.png /usr/share/eql5/examples/7-Sokoban/pics/wall.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/multimedia/video-widget/ui/designer/README.txt /usr/share/eql5/examples/M-modules/multimedia/video-graphics-item/ui/designer/README.txt eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/table-view/properties.lisp /usr/share/eql5/examples/M-modules/quick/Tic-Tac-Toe/properties.lisp:/usr/share/eql5/examples/M-modules/quick/item-model/properties.lisp:/usr/share/eql5/examples/M-modules/quick/painted-item/properties.lisp:/usr/share/eql5/examples/M-modules/quick/palindrome-2/properties.lisp:/usr/share/eql5/examples/M-modules/quick/qml-lisp/properties.lisp:(and 1 more) eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/definitions.lisp /usr/share/eql5/examples/M-modules/quick/palindrome-1/definitions.lisp eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml-file.lisp /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml-file.lisp eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/A.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/A.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/E.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/E.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/N.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/N.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/O.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/O.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/P.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/P.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/R.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/R.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/S.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/S.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/quick/palindrome-2/qml/img/T.png /usr/share/eql5/examples/M-modules/quick/palindrome-1/qml/img/T.png eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/webkit/README-GLUE-CODE.txt /usr/share/eql5/examples/M-modules/web-kit-engine/README-GLUE-CODE.txt:/usr/share/eql5/examples/M-modules/webkit/Examples-Browser/README-GLUE-CODE.txt eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.h /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.h:/usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.h eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.pro /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.pro eql5-examples.x86_64: W: files-duplicate /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.pro /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/webkit_bridge.pro eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/9-simple-lisp-editor/exe/main.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/9-simple-lisp-editor/send/send.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/web-kit-engine/lib/_invokables.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/web-kit-engine/lib/webkit_bridge.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/_invokables.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/webkit_bridge.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Examples-Browser/lib/webkit_bridge.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/_invokables.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/Tic-Tac-Toe/lib/webkit_bridge.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/lib/_invokables.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/M-modules/webkit/lib/webkit_bridge.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/move-blocks/cpp/lib.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/move-blocks/cpp/lib.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/palindrome/exe/main.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/palindrome/exe/main.h eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/qimage/cpp/lib.cpp eql5-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/eql5/examples/X-extras/qimage/cpp/lib.h 6 packages and 0 specfiles checked; 5 errors, 47 warnings, 61 filtered, 5 badness; has taken 2.7 s Unversioned so-files -------------------- eql5: /usr/lib64/eql5/libeql5_help.so eql5: /usr/lib64/eql5/libeql5_multimedia.so eql5: /usr/lib64/eql5/libeql5_network.so eql5: /usr/lib64/eql5/libeql5_quick.so eql5: /usr/lib64/eql5/libeql5_sql.so eql5: /usr/lib64/eql5/libeql5_svg.so eql5: /usr/lib64/eql5/libeql5_webengine.so Source checksums ---------------- https://gitlab.com/eql/EQL5/-/archive/440ac762a8345038c8fceb9ef0751b4b4d472342/EQL5-440ac762.tar.gz : CHECKSUM(SHA256) this package : 86179559f043462eff8ee437c2ec4593664ae9989cce9098e38dad7beac96743 CHECKSUM(SHA256) upstream package : 86179559f043462eff8ee437c2ec4593664ae9989cce9098e38dad7beac96743 Requires -------- eql5 (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Help.so.5()(64bit) libQt5Help.so.5(Qt_5)(64bit) libQt5Multimedia.so.5()(64bit) libQt5Multimedia.so.5(Qt_5)(64bit) libQt5MultimediaWidgets.so.5()(64bit) libQt5MultimediaWidgets.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5QuickWidgets.so.5()(64bit) libQt5QuickWidgets.so.5(Qt_5)(64bit) libQt5Sql.so.5()(64bit) libQt5Sql.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5WebEngineCore.so.5()(64bit) libQt5WebEngineCore.so.5(Qt_5)(64bit) libQt5WebEngineWidgets.so.5()(64bit) libQt5WebEngineWidgets.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libecl.so.23.9()(64bit) libeql5.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) eql5-devel (rpmlib, GLIBC filtered): eql5(x86-64) libeql5.so.1()(64bit) eql5-doc (rpmlib, GLIBC filtered): eql5-examples (rpmlib, GLIBC filtered): eql5-debuginfo (rpmlib, GLIBC filtered): eql5-debugsource (rpmlib, GLIBC filtered): Provides -------- eql5: eql5 eql5(x86-64) libeql5.so.1()(64bit) libeql5_help.so()(64bit) libeql5_multimedia.so()(64bit) libeql5_network.so()(64bit) libeql5_quick.so()(64bit) libeql5_sql.so()(64bit) libeql5_svg.so()(64bit) libeql5_webengine.so()(64bit) eql5-devel: eql5-devel eql5-devel(x86-64) eql5-doc: eql5-doc eql5-examples: eql5-examples eql5-examples(x86-64) eql5-debuginfo: debuginfo(build-id) eql5-debuginfo eql5-debuginfo(x86-64) libeql5.so.1.0.0-0^28022022.440ac762-1.fc40.x86_64.debug()(64bit) libeql5_help.so-0^28022022.440ac762-1.fc40.x86_64.debug()(64bit) libeql5_multimedia.so-0^28022022.440ac762-1.fc40.x86_64.debug()(64bit) libeql5_network.so-0^28022022.440ac762-1.fc40.x86_64.debug()(64bit) libeql5_quick.so-0^28022022.440ac762-1.fc40.x86_64.debug()(64bit) libeql5_sql.so-0^28022022.440ac762-1.fc40.x86_64.debug()(64bit) libeql5_svg.so-0^28022022.440ac762-1.fc40.x86_64.debug()(64bit) libeql5_webengine.so-0^28022022.440ac762-1.fc40.x86_64.debug()(64bit) eql5-debugsource: eql5-debugsource eql5-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2260121 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Ruby, SugarActivity, Perl, Haskell, PHP, fonts, R, Ocaml, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks for the review. Updating the package. Happy to co-maintain ecl, still learning about Lisp eco system.