Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://dcavalca.fedorapeople.org/review/python-memray/python-memray.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-memray/python-memray-1.11.0-1.fc40.src.rpm Description: Memray is a memory profiler for Python. It can track memory allocations in Python code, in native extension modules, and in the Python interpreter itself. It can generate several different types of reports to help you analyze the captured memory usage data. While commonly used as a CLI tool, it can also be used as a library to perform more fine-grained profiling tasks. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=112283695
Taking this review.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6947487 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260162-python-memray/fedora-rawhide-x86_64/06947487-python-memray/fedora-review/review.txt Found issues: - python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/alloc.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/compat.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/elf_utils.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/exceptions.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/frame_tree.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/hooks.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/linker_shenanigans.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/logging.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/lz4_stream.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/macho_utils.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/native_resolver.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/python_helpers.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/record_reader.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/record_writer.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/records.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/sink.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/snapshot.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/socket_reader_thread.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/source.h python3-memray : /usr/lib64/python3.12/site-packages/memray/_memray/tracking_api.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - License file furo.js.LICENSE.txt is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://dcavalca.fedorapeople.org/review/python-memray/python-memray.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-memray/python-memray-1.11.0-1.fc41.src.rpm Changelog - declare bundled js-furo doc dependency and its license
This should take care of one warning. As for the other: it looks like memray ships the Cython sources as part of the actual package. These could theoretically be removed (and I'm investigating whether that's feasible in practice), but should otherwise be harmless.
Spec URL: https://dcavalca.fedorapeople.org/review/python-memray/python-memray.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-memray/python-memray-1.11.0-1.fc41.src.rpm Changelog: - Exclude Cython sources from the package
A local fedora-review run revealed this: Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file licenses.doctree is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text I'm wondering if this is a whack-a-mole here?
Oh that comes from doctrees which is generally just cruft, I'll clobber it
Spec URL: https://dcavalca.fedorapeople.org/review/python-memray/python-memray.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-memray/python-memray-1.11.0-1.fc41.src.rpm Changelog: - clobber doctrees and other unnecessary cruft in -doc subpackage
Review notes: * Package follows Fedora Packaging Guidelines * Package follows Fedora Python Packaging Guidelines * Package builds and installs * Package licensing is correctly handled and recorded * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-memray
FEDORA-2024-46c1d43602 (python-memray-1.11.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-46c1d43602
FEDORA-2024-46c1d43602 (python-memray-1.11.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-950238e5b4 (python-memray-1.11.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-950238e5b4
FEDORA-2024-950238e5b4 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-950238e5b4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-950238e5b4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-950238e5b4 (python-memray-1.11.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.