Bug 226028 - Merge Review: libIDL
Merge Review: libIDL
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Susi Lehtola
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:25 EST by Nobody's working on this, feel free to take it
Modified: 2010-08-19 14:22 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-08-18 16:49:54 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
susi.lehtola: fedora‑review+


Attachments (Terms of Use)
Patch against rawhide spec (27.35 KB, patch)
2010-08-18 16:47 EDT, Susi Lehtola
no flags Details | Diff
Patch against rawhide spec (1.73 KB, patch)
2010-08-18 17:44 EDT, Susi Lehtola
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:25:17 EST
Fedora Merge Review: libIDL

http://cvs.fedora.redhat.com/viewcvs/devel/libIDL/
Initial Owner: mclasen@redhat.com
Comment 1 Susi Lehtola 2009-03-27 16:17:31 EDT
rpmlint output:
libIDL.src: W: no-url-tag
libIDL.x86_64: W: no-url-tag
libIDL.x86_64: W: shared-lib-calls-exit /usr/lib64/libIDL-2.so.0.0.0 exit@GLIBC_2.2.5
libIDL-debuginfo.x86_64: W: no-url-tag
libIDL-devel.x86_64: W: no-url-tag
4 packages and 0 specfiles checked; 0 errors, 5 warnings.

- Add source url, maybe will have to do with just
http://ftp.gnome.org/pub/gnome/sources/libIDL/
 if software does not have a homepage.

- Enable SMP make.

- For info file installation change
Requires(post): /sbin/install-info
to
Requires(post):         info
Requires(preun):        info


MUST: The spec file for the package is legible and macros are used consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the  Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license. NEEDSFIX
 - ltmain.sh, parser.c and parser.h are under GPLv2+. License should thus probably be LGPLv2+ and GPLv2+.

MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK

MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSFIX
 - Add BUGS and MAINTAINERS to %doc.

MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. OK
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK
MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK

MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK
 - You might want to change the requires to %{name} instead of libIDL.

MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
Comment 2 Susi Lehtola 2009-04-24 16:49:42 EDT
Ping.
Comment 3 Matthias Clasen 2009-04-24 17:06:26 EDT
MUST: The License field in the package spec file must match the actual license.
NEEDSFIX
 - ltmain.sh, parser.c and parser.h are under GPLv2+. License should thus
probably be LGPLv2+ and GPLv2+.

ltmain.sh is a part of libtool. I don't see how that could be relevant for the license of this package.
Comment 4 Susi Lehtola 2009-04-24 17:11:54 EDT
(In reply to comment #3)
> MUST: The License field in the package spec file must match the actual license.
> NEEDSFIX
>  - ltmain.sh, parser.c and parser.h are under GPLv2+. License should thus
> probably be LGPLv2+ and GPLv2+.
> 
> ltmain.sh is a part of libtool. I don't see how that could be relevant for the
> license of this package.  

Duh, what have I been thinking..
Comment 5 Susi Lehtola 2009-04-24 17:21:28 EDT
parser.c states:

"  As a special exception, you may create a larger work that contains
   part or all of the Bison parser skeleton and distribute that work
   under terms of your choice, so long as that work isn't itself a
   parser generator using the skeleton or a modified version thereof
   as a parser skeleton."

So the licensing is probably OK after all.
Comment 6 Susi Lehtola 2009-06-14 12:06:03 EDT
ping?
Comment 7 Susi Lehtola 2009-08-05 07:23:57 EDT
ping again?
Comment 8 Matthias Clasen 2009-08-05 09:49:56 EDT
ping what ? kindly state what you want
Comment 9 Susi Lehtola 2009-08-05 10:08:43 EDT
(In reply to comment #8)
> ping what ? kindly state what you want  

Please address the issues in comment #1 (except the license issue which was cleared out) so that the package can be approved and the merge review closed.
Comment 10 Susi Lehtola 2010-01-01 17:46:01 EST
ping mclasen
Comment 11 Susi Lehtola 2010-08-18 16:47:41 EDT
Created attachment 439502 [details]
Patch against rawhide spec
Comment 12 Susi Lehtola 2010-08-18 16:49:54 EDT
See patch in comment #11 for suggested changes. Now as I look at them, they're mostly cosmetic, so I don't see any reason not to approve this review.

APPROVED

Maybe you'll want to go through them quickly, anyhow.
Comment 13 Susi Lehtola 2010-08-18 17:44:17 EDT
Created attachment 439520 [details]
Patch against rawhide spec
Comment 14 Matthias Clasen 2010-08-19 10:52:55 EDT
Patch looks fine to commit, no objections. If you have the privileges to do a build with it, feel free to that too. Otherwise, I'll do it at some point.
Comment 15 Susi Lehtola 2010-08-19 14:22:13 EDT
OK, all done!

Note You need to log in before you can comment on or make changes to this bug.