Bug 226029 - Merge Review: libidn
Merge Review: libidn
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jon Ciesla
Fedora Package Reviews List
:
Depends On:
Blocks: F9MergeReviewTarget
  Show dependency treegraph
 
Reported: 2007-01-31 14:25 EST by Nobody's working on this, feel free to take it
Modified: 2010-08-02 16:00 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-02-07 10:56:07 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
limburgher: fedora‑review+


Attachments (Terms of Use)
Patch to correct encodings. (749 bytes, patch)
2007-12-26 15:50 EST, Jon Ciesla
no flags Details | Diff
Second patch to fix buildroot tag. (478 bytes, patch)
2007-12-26 16:32 EST, Jon Ciesla
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:25:30 EST
Fedora Merge Review: libidn

http://cvs.fedora.redhat.com/viewcvs/devel/libidn/
Initial Owner: jorton@redhat.com
Comment 1 Jon Ciesla 2007-12-26 15:18:20 EST
rpmlint for SRPM is clean.
For RPM:
libidn.i386: W: file-not-utf8 /usr/share/info/libidn.info.gz
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

libidn-devel.i386: W: file-not-utf8
/usr/share/doc/libidn-devel-0.6.14/examples/example3.c
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

libidn-devel.i386: W: file-not-utf8
/usr/share/doc/libidn-devel-0.6.14/examples/example4.c
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

libidn-devel.i386: W: file-not-utf8
/usr/share/doc/libidn-devel-0.6.14/examples/example.c
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).


In the spec, running something like iconv -f ISO-8859 -t UTF-8 filename should
do the trick.
Comment 2 Jon Ciesla 2007-12-26 15:50:52 EST
Created attachment 290422 [details]
Patch to correct encodings.
Comment 3 Jon Ciesla 2007-12-26 15:59:03 EST
Use %{buildroot} or $RPM_BUILD_ROOT, not both.

Use one of the 3 approved buildroot values:
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
%{_tmppath}/%{name}-%{version}-%{release}-root

Otherwise, it looks good, no other blockers.
Comment 4 Jon Ciesla 2007-12-26 16:32:59 EST
Created attachment 290427 [details]
Second patch to fix buildroot tag.
Comment 5 Joe Orton 2008-02-07 10:33:24 EST
The encodings of at least some of the example C code is deliberate; it's not
right to convert those to UTF-8.  I've applied the patch to convert the info
file though, and also the BuildRoot tag fix - thanks a lot!

http://koji.fedoraproject.org/koji/buildinfo?buildID=34473
Comment 6 Jon Ciesla 2008-02-07 10:56:07 EST
Fabulous, APPROVED.

You're very welcome!
Comment 7 Paul Howarth 2010-08-02 16:00:25 EDT
(In reply to comment #5)
> The encodings of at least some of the example C code is deliberate; it's not
> right to convert those to UTF-8.  I've applied the patch to convert the info
> file though,

Actually the same can be said of the info file, and the INFO-DIR-SECTION bits don't mention GNU any more, so the sed in %prep isn't having any effect now.

Note You need to log in before you can comment on or make changes to this bug.