Fedora Merge Review: libidn http://cvs.fedora.redhat.com/viewcvs/devel/libidn/ Initial Owner: jorton
rpmlint for SRPM is clean. For RPM: libidn.i386: W: file-not-utf8 /usr/share/info/libidn.info.gz The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). libidn-devel.i386: W: file-not-utf8 /usr/share/doc/libidn-devel-0.6.14/examples/example3.c The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). libidn-devel.i386: W: file-not-utf8 /usr/share/doc/libidn-devel-0.6.14/examples/example4.c The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). libidn-devel.i386: W: file-not-utf8 /usr/share/doc/libidn-devel-0.6.14/examples/example.c The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). In the spec, running something like iconv -f ISO-8859 -t UTF-8 filename should do the trick.
Created attachment 290422 [details] Patch to correct encodings.
Use %{buildroot} or $RPM_BUILD_ROOT, not both. Use one of the 3 approved buildroot values: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %{_tmppath}/%{name}-%{version}-%{release}-root Otherwise, it looks good, no other blockers.
Created attachment 290427 [details] Second patch to fix buildroot tag.
The encodings of at least some of the example C code is deliberate; it's not right to convert those to UTF-8. I've applied the patch to convert the info file though, and also the BuildRoot tag fix - thanks a lot! http://koji.fedoraproject.org/koji/buildinfo?buildID=34473
Fabulous, APPROVED. You're very welcome!
(In reply to comment #5) > The encodings of at least some of the example C code is deliberate; it's not > right to convert those to UTF-8. I've applied the patch to convert the info > file though, Actually the same can be said of the info file, and the INFO-DIR-SECTION bits don't mention GNU any more, so the sed in %prep isn't having any effect now.