Fedora Merge Review: libiec61883 http://cvs.fedora.redhat.com/viewcvs/devel/libiec61883/ Initial Owner: jwilson
Created attachment 449373 [details] spec cleanup Please commit the attached patch that will clean this spec or allow to commit it.
Really only need to see the bz traffic once, thank you. ;) (jarod@ == jwilson@) Most of the changes look fine, though your patch removes %clean entirely from the spec. I have vague recollections that this may now be implied w/current rpm, but is that true for all current Fedora releases?
(In reply to comment #2) > Really only need to see the bz traffic once, thank you. ;) (jarod@ == jwilson@) > Welcome. > Most of the changes look fine, though your patch removes %clean entirely from > the spec. I have vague recollections that this may now be implied w/current > rpm, but is that true for all current Fedora releases? From http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean, "The %clean section is not required for F-13 and above. Each package for F-12 and below (or EPEL) MUST have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT)."
Is the patch committed?
ping
Committed the above patch and built in libiec61883-1.2.0-5.fc15 APPROVED.