Bug 226030 - Merge Review: libiec61883
Merge Review: libiec61883
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:25 EST by Nobody's working on this, feel free to take it
Modified: 2010-10-22 00:36 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-10-22 00:36:02 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)
spec cleanup (2.35 KB, patch)
2010-09-24 05:06 EDT, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:25:34 EST
Fedora Merge Review: libiec61883

http://cvs.fedora.redhat.com/viewcvs/devel/libiec61883/
Initial Owner: jwilson@redhat.com
Comment 1 Parag AN(पराग) 2010-09-24 05:06:52 EDT
Created attachment 449373 [details]
spec cleanup

Please commit the attached patch that will clean this spec or allow to commit it.
Comment 2 Jarod Wilson 2010-09-24 09:57:16 EDT
Really only need to see the bz traffic once, thank you. ;) (jarod@ == jwilson@)

Most of the changes look fine, though your patch removes %clean entirely from the spec. I have vague recollections that this may now be implied w/current rpm, but is that true for all current Fedora releases?
Comment 3 Parag AN(पराग) 2010-09-24 10:07:10 EDT
(In reply to comment #2)
> Really only need to see the bz traffic once, thank you. ;) (jarod@ == jwilson@)
> 

Welcome.

> Most of the changes look fine, though your patch removes %clean entirely from
> the spec. I have vague recollections that this may now be implied w/current
> rpm, but is that true for all current Fedora releases?

From http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean,

"The %clean section is not required for F-13 and above. Each package for F-12 and below (or EPEL) MUST have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT)."
Comment 4 Parag AN(पराग) 2010-09-29 00:03:05 EDT
Is the patch committed?
Comment 5 Parag AN(पराग) 2010-10-12 02:21:08 EDT
ping
Comment 6 Parag AN(पराग) 2010-10-22 00:36:02 EDT
Committed the above patch and built in libiec61883-1.2.0-5.fc15

APPROVED.

Note You need to log in before you can comment on or make changes to this bug.