Bug 226031 - Merge Review: libieee1284
Merge Review: libieee1284
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Susi Lehtola
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 14:25 EST by Nobody's working on this, feel free to take it
Modified: 2009-05-14 10:57 EDT (History)
2 users (show)

See Also:
Fixed In Version: 0.2.11-6.fc12
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-05-14 07:15:36 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
susi.lehtola: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:25:36 EST
Fedora Merge Review: libieee1284

Initial Owner: twaugh@redhat.com
Comment 2 Tim Waugh 2008-02-13 07:45:24 EST
Sorry, please ignore comment #1.
Comment 3 Susi Lehtola 2009-03-27 15:37:40 EDT
- Drop the obsolete prereq. (ldconfig is part of glibc which is automatically available so no buildreqs are needed for it.)

- Change devel package requires to %{name} = %{version}-%{release}.

- Use SMP make and drop optflags from make line (already put in by %configure). Make line should read
  make %{?_smp_mflags}

- Devel package needs to provide %{name}-static = %{version}-%{release}

- .la files should be removed (although this is considered an ABI change and can only be done in rawhide)

- Source url is incorrect, should be
Comment 4 Susi Lehtola 2009-03-27 15:46:59 EDT
rpmlint output:
libieee1284.src:9: E: prereq-use /sbin/ldconfig
libieee1284-devel.x86_64: W: summary-ended-with-dot Files for developing applications that use libieee1284.
libieee1284-python.x86_64: W: no-documentation
libieee1284-python.x86_64: W: summary-ended-with-dot Python extension module for libieee1284.
5 packages and 0 specfiles checked; 1 errors, 3 warnings.

- Remove the dot and drop the prereq.

MUST: The spec file for the package is legible and macros are used consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the  Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK

MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. NEEDSFIX 

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK

MUST: Optflags are used and time stamps preserved. OK
 - Use
  make DESTDIR=%{buildroot} INSTALL="install -p" install
  just to be safe.

MUST: Packages containing shared library files must call ldconfig. OK
NUST: A package must own all directories that it creates or require the package that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK

MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSFIX
 - Include AUTHORS and NEWS to documentation.

MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. NEEDSFIX
 - See #3.

MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK
MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK

MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. NEEDSFIX
MUST: Packages does not contain any .la libtool archives. NEEDSFIX

MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
Comment 5 Tim Waugh 2009-05-14 07:15:36 EDT
Fixes made.  Thanks!
Comment 6 Susi Lehtola 2009-05-14 08:48:28 EDT
Okay, seems good.


PS. You can still drop the dot in the python package summary:
Summary: Python extension module for libieee1284.
Comment 7 Tim Waugh 2009-05-14 10:57:14 EDT
Oops, missed that one, thanks.  Done.

Note You need to log in before you can comment on or make changes to this bug.