Spec URL: https://decathorpe.fedorapeople.org/rust-capnpc.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-capnpc-0.18.1-1.fc39.src.rpm Description: Cap'n Proto code generation. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=112342097
Copr build: https://copr.fedorainfracloud.org/coprs/build/6951651 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260349-rust-capnpc/fedora-rawhide-x86_64/06951651-rust-capnpc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This looks good to me except for two things: - There is a new version, 0.19.0, released since this issue was opened. Please update unless the packages you intend to depend on this are not yet compatible. - The capnpc subpackage still needs the license breakdown comment and License field filled in: # FIXME: paste output of %%cargo_license_summary here License: # FIXME
Oops, not sure how I could have missed the FIXME. I've removed the executables (I don't need them) - I only need the library interface. I cannot package v0.19 yet, since other capnp* crates in Fedora are stuck at v0.18 too, and the thing I'm packaging this for also needs v0.18. All capnp* crates can only be updated to the v0.19 branch together. Updated files behind the same URLs.
(In reply to Fabio Valentini from comment #4) > Oops, not sure how I could have missed the FIXME. > I've removed the executables (I don't need them) - I only need the library > interface. I tend to like packaging binaries when there aren’t conflicts or other great hardships standing in the way, but I can see why it’s easier for you to drop them, and I suppose they’re only a PR or bug report away, if someone ends up needing them. > I cannot package v0.19 yet, since other capnp* crates in Fedora are stuck at > v0.18 too, and the thing I'm packaging this for also needs v0.18. All capnp* > crates can only be updated to the v0.19 branch together. Makes sense; I suspected that might be the case. > Updated files behind the same URLs. Thanks. Full review to follow.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec is based on the one generated by rust2rpm, simplifying the review. Cargo.toml is patched so that the binaries capnpc-rust and capnpc-rust-bootstrap are not built; rust2rpm therefore generates no capnpc subpackage, only the source-only rust-capnpc-devel crate library subpackage. Otherwise, the following differences are noted: - A test is skipped. - A spec-file comment is added to justify/explain capnpc-fix-metadata.diff. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/capnpc-0.18.1/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is not a serious problem; if it should be fixed, then it should be fixed in rust2rpm. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 8 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2260349-rust-capnpc/re-review/2260349-rust- capnpc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/cargo/registry, /usr/share/cargo This diagnostic is a fedora-review bug. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- capnpc-devel , rust-capnpc+default-devel [x]: Package functions as described. (tests pass) [!]: Latest version is packaged. Version 0.19.0 is available, but holding back to 0.18.1 is justified by interdependencies with other packages. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=113715528 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-capnpc-devel-0.18.1-1.fc41.noarch.rpm rust-capnpc+default-devel-0.18.1-1.fc41.noarch.rpm rust-capnpc-0.18.1-1.fc41.src.rpm =========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxz_fitvz')] checks: 32, packages: 3 rust-capnpc+default-devel.noarch: E: spelling-error ("Cap'n", "Summary(en_US) Cap'n -> Cap's, Capon") rust-capnpc+default-devel.noarch: E: spelling-error ("Cap'n", "%description -l en_US Cap'n -> Cap's, Capon") rust-capnpc.src: E: spelling-error ("Cap'n", "Summary(en_US) Cap'n -> Cap's, Capon") rust-capnpc.src: E: spelling-error ("Cap'n", "%description -l en_US Cap'n -> Cap's, Capon") rust-capnpc-devel.noarch: E: spelling-error ("Cap'n", "Summary(en_US) Cap'n -> Cap's, Capon") rust-capnpc-devel.noarch: E: spelling-error ("Cap'n", "%description -l en_US Cap'n -> Cap's, Capon") rust-capnpc+default-devel.noarch: W: no-documentation ===================================================== 3 packages and 0 specfiles checked; 6 errors, 1 warnings, 12 filtered, 6 badness; has taken 0.4 s ===================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 rust-capnpc-devel.noarch: E: spelling-error ("Cap'n", "Summary(en_US) Cap'n -> Cap's, Capon") rust-capnpc-devel.noarch: E: spelling-error ("Cap'n", "%description -l en_US Cap'n -> Cap's, Capon") rust-capnpc+default-devel.noarch: E: spelling-error ("Cap'n", "Summary(en_US) Cap'n -> Cap's, Capon") rust-capnpc+default-devel.noarch: E: spelling-error ("Cap'n", "%description -l en_US Cap'n -> Cap's, Capon") rust-capnpc+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 8 filtered, 4 badness; has taken 0.2 s Source checksums ---------------- https://crates.io/api/v1/crates/capnpc/0.18.1/download#/capnpc-0.18.1.crate : CHECKSUM(SHA256) this package : a642faaaa78187e70bdcc0014c593c213553cfeda3b15054426d0d596048b131 CHECKSUM(SHA256) upstream package : a642faaaa78187e70bdcc0014c593c213553cfeda3b15054426d0d596048b131 Requires -------- rust-capnpc-devel (rpmlib, GLIBC filtered): (crate(capnp/default) >= 0.18.0 with crate(capnp/default) < 0.19.0~) cargo rust-capnpc+default-devel (rpmlib, GLIBC filtered): cargo crate(capnpc) Provides -------- rust-capnpc-devel: crate(capnpc) rust-capnpc-devel rust-capnpc+default-devel: crate(capnpc/default) rust-capnpc+default-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2260349 --mock-options=--dnf Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, C/C++, fonts, Java, Haskell, Python, Perl, SugarActivity, Ocaml, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-capnpc
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fdd4e26fe9