Fedora Merge Review: libpng http://cvs.fedora.redhat.com/viewcvs/devel/libpng/ Initial Owner: tgl
Good: * Source URL in canonical. * Group Tag is from official list. * All paths begin with macros * All directories are owned by this or other packages Must Fix: * rpmlint errors: E: libpng useless-explicit-provides libpng.so.3 E: libpng tag-not-utf8 %changelog Minor: * Not preferred build root. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * Drop the '.' from the devel summary to quite rpmlint. Is it still true that some graphical boot packages need the static lib? And if so, does it make sense to make a sub-package for the static lib?
Thanks for the review --- all those points are good. As for the question about the static library, I'm not sure what to do. The previous package owner of libjpeg dropped its static library and there's been a bunch of push-back about that, which makes me wary of doing it to libpng. Perhaps a sub-package is the answer; is there any precedent for that?
See also: http://fedoraproject.org/wiki/PackagingDrafts/StaticLinkage recommendation is to package it separately, something like libpng-static
All these issues are addressed in libpng-1.2.16.
Hey, folks, why is this ticket closed? Did someone approve it?
Not that I can see, reopening (probably goofed up in the period of review rules confusion)
I closed it because I'd fixed the mentioned issues. If that's not proper procedure, my fault; but I'm not sure why the bug should be ASSIGNED to me when there is not anything apparent for me to do.
I spotted that a better url is certainly http://www.libpng.org/pub/png/libpng.html make install DESTDIR=$RPM_BUILD_ROOT is preferred over %makeinstall Would it work here? Suggestions: use %defattr(-,root,root,-) instead of %defattr(-,root,root) Document the Conflict with qt < 0:2.2.2 I reassign to nobody, as per the new new guidelines, this should be assigned to the reviewer doing the formal review.
Source match upstream, but source timestamp isn't the same than upstream. Next time, please keep timestamp, with spectool -g or wget -N for example.
Another minor suggestion: in rm -rf $RPM_BUILD_ROOT%{_libdir}/libpng.la you can remove the -r since it is not a directory, and you could even remove the -f such that the command fails if one day the file name change or there are no la shipped.
Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket: https://fedorahosted.org/fesco/ticket/1269 If you don't know what merge reviews are about, please see: https://fedoraproject.org/wiki/Merge_Reviews How to handle this bug is left to the discretion of the package maintainer.
I have updated libpng.spec file: scm-commit rawhide: https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20150302/1528991.html rm -rf $RPM_BUILD_ROOT%{_libdir}/*.la -r was removed rpmlint results: $ rpmlint libpng.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23
The bug can closed so that all issues are fixed.