This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours
Bug 226042 - Merge Review: libselinux
Merge Review: libselinux
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Adel Gadllah
Fedora Package Reviews List
:
Depends On:
Blocks: F9MergeReviewTarget
  Show dependency treegraph
 
Reported: 2007-01-31 14:27 EST by Nobody's working on this, feel free to take it
Modified: 2008-01-21 17:20 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-21 17:20:40 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
adel.gadllah: fedora‑review+


Attachments (Terms of Use)
Patch to adress remaining spec file issues (2.19 KB, patch)
2008-01-16 15:19 EST, Adel Gadllah
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:27:17 EST
Fedora Merge Review: libselinux

http://cvs.fedora.redhat.com/viewcvs/devel/libselinux/
Initial Owner: dwalsh@redhat.com
Comment 1 Adel Gadllah 2008-01-01 16:30:35 EST
OK taking this one:

First the rpmlint warnings/errors:

-----------------
> libselinux.x86_64: W: invalid-license Public domain
> libselinux.x86_64: W: invalid-license uncopyrighted
-----------------
The license tag is indeed invalid it should be 
"Public Domain" 
See: http://fedoraproject.org/wiki/Licensing
-----------------
> libselinux.x86_64: W: no-url-tag
-----------------
Why? Please add an URL tag pointing to the upstream homepage
-----------------
> libselinux-python.x86_64: E: script-without-shebang >
/usr/lib64/python2.5/site-packages/selinux.py
-----------------
As this file is not intended to be executed directly chmod -x it (mode 0644 not
0755) (If it is then please add a shebang)
-----------------
libselinux-python.x86_64: W: summary-not-capitalized python bindings for libselinux
-----------------
OK thats an easy one ;)
-----------------
libselinux-python.x86_64: E: description-line-too-long The libselinux-python
package contains the python bindings for developing SELinux
-----------------
Please split this into 80 char lines.
-----------------

Now general comments to the spec file:

>%files devel
>%defattr(-,root,root)
>%{_libdir}/libselinux.a

Please remove this file or if you want to ship it for some reason place it in a
-static subpackage.


------

>%files python
>%defattr(-,root,root,0755)
>%{_libdir}/python*/site-packages/_selinux.so
>%{_libdir}/python*/site-packages/selinux.py*

Instead of {_libdir}/python*/site-packages do this:
Add 
%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
to the top of the spec file and use %{python_sitelib} instead.
------

>%build
>make clean
>make CFLAGS="-g %{optflags}" swigify
>make CFLAGS="-g %{optflags}" all pywrap

Please append %{?_smp_mflags} to the make calls (if it does not break the build).

====
If you want I can attach a patch with the changes mentioned above to help
speeding up the review process.
Comment 2 Daniel Walsh 2008-01-03 15:39:55 EST
Fixes are in libselinux-2.0.46-3

Thanks.
Comment 3 Adel Gadllah 2008-01-03 19:32:28 EST
(In reply to comment #2)
> Fixes are in libselinux-2.0.46-3
> 
> Thanks.

OK, the rpmlint output is now:
"libselinux-python.x86_64: W: no-documentation"
which is fine!

The only remaining issue is the python site-packages path.
Once fixed I will approve the package.
Comment 4 Adel Gadllah 2008-01-04 12:24:52 EST
one more thing:
>%defattr(-,root,root,0755)
should be replaced with
>%defattr(-,root,root,0755) 
(set the correct modes during %install)
Comment 5 Daniel Walsh 2008-01-04 14:19:26 EST
adel you are replacing one command with the same.
Comment 6 Adel Gadllah 2008-01-15 11:54:38 EST
(In reply to comment #5)
> adel you are replacing one command with the same.

... stupid copy and paste sorry; 
I meant "%defattr(-,root,root,-)"
Comment 7 Adel Gadllah 2008-01-16 15:19:25 EST
Created attachment 291883 [details]
Patch to adress remaining spec file issues

Daniel, this patch should fixes the issues I mentioned in this bug. I moved
libselinux.a into a -static package because it seems to be needed.
Comment 8 Daniel Walsh 2008-01-21 15:59:42 EST
fixed in libselinux-2.0.47-4.fc9
Comment 9 Adel Gadllah 2008-01-21 16:48:26 EST
(In reply to comment #8)
> fixed in libselinux-2.0.47-4.fc9

Looks fine now.

=> APPROVED!

Note You need to log in before you can comment on or make changes to this bug.