Bug 226060 - Merge Review: libwpd
Merge Review: libwpd
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Thomas Spura
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:29 EST by Nobody's working on this, feel free to take it
Modified: 2010-07-19 09:58 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-07-19 09:58:07 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tomspur: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:29:05 EST
Fedora Merge Review: libwpd

http://cvs.fedora.redhat.com/viewcvs/devel/libwpd/
Initial Owner: caolanm@redhat.com
Comment 1 Thomas Spura 2010-07-19 08:57:28 EDT
$ rpmlint ./libwpd-0.8.14-4.fc13.src.rpm x86_64/libwpd-*
libwpd-tools.x86_64: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
libwpd-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wpd2text ['/usr/lib64']
libwpd-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wpd2html ['/usr/lib64']
libwpd-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wpd2raw ['/usr/lib64']
libwpd-tools.x86_64: W: no-documentation
libwpd-tools.x86_64: W: no-manual-page-for-binary wpd2raw
libwpd-tools.x86_64: W: no-manual-page-for-binary wpd2html
libwpd-tools.x86_64: W: no-manual-page-for-binary wpd2text
5 packages and 0 specfiles checked; 3 errors, 5 warnings.

See: https://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath

- please add a %check section (needs BR cppunit-devel):
%check
make check

- in %description tools:
  Could be that there is a '(tm)' missing behind 'WordPerfect', isn't it?
  (Same in main package)


Anything else looks ok:
- name ok
- license ok
- group ok
- libs correctly installed
- no locales
- no static libs
- parallel make
- %files ok
- subpackages require main package implicitely
- no *.la
Comment 2 Caolan McNamara 2010-07-19 09:32:53 EDT
a) E: binary-or-shlib-defines-rpath
done as libwpd-0.8.14-5.fc14

b) make check
done as libwpd-0.8.14-5.fc14

c) (tm)
as per http://fedoraproject.org/wiki/PackagingGuidelines#Trademarks_in_Summary_or_Description
removed it altogether, done as libwpd-0.8.14-5.fc14
Comment 3 Thomas Spura 2010-07-19 09:58:07 EDT
Great.

New rpmlint:
$ rpmlint ./libwpd-0.8.14-5.fc13.src.rpm x86_64/libwpd-*
libwpd-tools.x86_64: W: no-documentation
libwpd-tools.x86_64: W: no-manual-page-for-binary wpd2raw
libwpd-tools.x86_64: W: no-manual-page-for-binary wpd2html
libwpd-tools.x86_64: W: no-manual-page-for-binary wpd2text
5 packages and 0 specfiles checked; 0 errors, 4 warnings.

All ignorable.

________________________________________________________________________________


APPROVED

Note You need to log in before you can comment on or make changes to this bug.