Spec URL: https://repo.calcforge.org/review/plasma-workspace-x11.spec SRPM URL: https://repo.calcforge.org/review/plasma-workspace-x11-5.92.0-1.fc40.src.rpm Description: Xorg support for Plasma. Fedora Account System Username: kkofler
This is part two of "unbreak KDE". Hopefully the last one. (At least, kwin and plasma-workspace are the only packages that are rebuilt in the ngompa/kde6-x11-unsupported Copr.) Successful Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=112522760 Has a runtime-only dependency on kwin-x11 (see review bug #2260793).
Copr build: https://copr.fedorainfracloud.org/coprs/build/6969142 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260798-plasma-workspace-x11/fedora-rawhide-x86_64/06969142-plasma-workspace-x11/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The BuildRequires are copied from plasma-workspace. The Qt/KDE -devel files drag in gcc-c++ transitively, but I suppose I could add it explicitly.
Note: This package has the same issue as kwin-x11 as noted here: https://bugzilla.redhat.com/show_bug.cgi?id=2260793#c9 Introducing it the way it is right now would break part of the the implementation of the Plasma 6 Change.
I do not think it actually would, see: https://bugzilla.redhat.com/show_bug.cgi?id=2260793#c10
> Introducing it the way it is right now would break part of the the implementation of the Plasma 6 Change. No, it would not. I can prove it: https://bugzilla.redhat.com/show_bug.cgi?id=2260793#c13
At today's meeting, FESCo agreed to a preliminary injunction while we consider this issue. Until otherwise notified, these packages (kwin-X11 and plasma-workspace-x11) may not be re-admitted to Fedora. This decision is NOT final, but FESCo needs time to consider what to do here. https://pagure.io/fesco/issue/3165
As per https://bugzilla.redhat.com/show_bug.cgi?id=2260793#c24, a suggested longer %description: %description Support for the legacy X11 window system in KDE Plasma instead of the default Wayland. This package provides the legacy "Plasma (X11)" session type and the startplasma-x11 executable required by that session type. (It also contains a dependency on kwin-x11, the legacy X11 version of the KDE Window Manager (KWin).) This version is maintained by individual Fedora packagers and NOT supported by the Fedora KDE SIG. (See plasma-workspace-wayland for the default version, using Wayland, maintained by the KDE SIG.)
Though maybe it should say "in addition to" instead of "instead of", since this does NOT conflict with plasma-workspace-wayland and you will probably not be able to remove plasma-workspace-wayland due to dependencies.
If it does not conflict with plasma-workspace-wayland, then yes, this package would add just additional session type. I would omit (It also contains a dependency on kwin-x11, the legacy X11 version of the KDE Window Manager (KWin).). This is would be visible from dnf or rpm -q. I would add brief description from upstream README. %description Plasma Workspace is used as the base for Plasma Desktop, Mobile, and Bigscreen. It contains shared KCMs, applets as well as multiple libraries. Support for the legacy X11 window system in KDE Plasma instead of the default Wayland. This package provides the legacy "Plasma (X11)" session type and the startplasma-x11 executable required by that session type. This version is maintained by individual Fedora packagers and NOT supported by the Fedora KDE SIG. (See plasma-workspace-wayland for the default version, using Wayland, maintained by the KDE SIG.)
Can we coordinate this with https://src.fedoraproject.org/rpms/plasma-workspace/pull-request/29 and https://src.fedoraproject.org/rpms/kwin/pull-request/12 to avoid bumping the epoch here?
Yes, we can do that.
(In reply to Alessandro Astone from comment #11) > Can we coordinate this with > https://src.fedoraproject.org/rpms/plasma-workspace/pull-request/29 and > https://src.fedoraproject.org/rpms/kwin/pull-request/12 to avoid bumping the > epoch here? I would be grateful if this was done, it seems to me that it is the most rational but I think you need rebase the PR(s) best regards,
Done.
from https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260798-plasma-workspace-x11/fedora-rawhide-x86_64/06969142-plasma-workspace-x11/fedora-review/review.txt and reviewing the spec no issues found , BTW we may also need add SDDM-X11 if is not in this package ... please remove EPOCH before import the package PACKAGE APPROVED
Spec URL: https://repo.calcforge.org/review/plasma-workspace-x11.spec SRPM URL: https://repo.calcforge.org/review/plasma-workspace-x11-5.92.0-7.fc40.src.rpm Description: Support for the legacy X11 window system in KDE Plasma, as opposed to the default Wayland. This package provides the legacy "Plasma (X11)" session type and the startplasma-x11 executable required by that session type. (Other requirements such as kwin-x11 are found in the package dependencies.) The session type can be switched between "Plasma (X11)" and the default "Plasma (Wayland)" in the display manager (e.g., SDDM). This version is maintained by individual Fedora packagers and NOT supported by the Fedora KDE SIG. (See plasma-workspace-wayland for the default version, using Wayland, maintained by the KDE SIG.) Fedora Account System Username: kkofler * Fri Feb 16 2024 Kevin Kofler <…> - 5.92.0-7 - Drop Epoch again, the Obsoletes in -wayland was tightened - Explicitly BuildRequires: cmake and gcc-c++ - Improve %%description This addresses the comments that have come up during review.
> BTW we may also need add SDDM-X11 if is not in this package ... SDDM still ships sddm-x11 for now. If they drop it, I will have to package that, too.
(In reply to Kevin Kofler from comment #16) > Spec URL: https://repo.calcforge.org/review/plasma-workspace-x11.spec > SRPM URL: > https://repo.calcforge.org/review/plasma-workspace-x11-5.92.0-7.fc40.src.rpm > Description: > Support for the legacy X11 window system in KDE Plasma, as opposed to the > default Wayland. This package provides the legacy "Plasma (X11)" session type > and the startplasma-x11 executable required by that session type. (Other > requirements such as kwin-x11 are found in the package dependencies.) The > session type can be switched between "Plasma (X11)" and the default "Plasma > (Wayland)" in the display manager (e.g., SDDM). > > This version is maintained by individual Fedora packagers and NOT supported > by > the Fedora KDE SIG. (See plasma-workspace-wayland for the default version, > using > Wayland, maintained by the KDE SIG.) > > Fedora Account System Username: kkofler > > * Fri Feb 16 2024 Kevin Kofler <…> - 5.92.0-7 > - Drop Epoch again, the Obsoletes in -wayland was tightened > - Explicitly BuildRequires: cmake and gcc-c++ > - Improve %%description > > This addresses the comments that have come up during review. perfect please do: fedpkg request-repo https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_New_Contributors/#add_package_to_source_code_management_scm_system_and_set_owner
The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-workspace-x11