Bug 226088 - Merge Review: libxslt
Summary: Merge Review: libxslt
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2007-01-31 19:33 UTC by Nobody's working on this, feel free to take it
Modified: 2010-10-28 05:40 UTC (History)
4 users (show)

Fixed In Version: libxslt-1.1.26-5.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-10-28 05:40:37 UTC
Type: ---
panemade: fedora-review+

Attachments (Terms of Use)
spec cleanup (4.68 KB, patch)
2010-10-11 09:34 UTC, Parag AN(पराग)
no flags Details | Diff
More careful approach to charset conversion (4.23 KB, patch)
2010-10-22 17:20 UTC, Paul Howarth
no flags Details | Diff

Description Nobody's working on this, feel free to take it 2007-01-31 19:33:00 UTC
Fedora Merge Review: libxslt

Initial Owner: veillard@redhat.com

Comment 1 Parag AN(पराग) 2010-10-11 09:34:17 UTC
Created attachment 452672 [details]
spec cleanup

Please commit this git patch to clean this package as per packaging guidelines or allow to commit it.

Comment 2 Parag AN(पराग) 2010-10-11 10:15:52 UTC
Following are the changes proposed in above patch
1) Generally we used to have dependent packages already built in repo so I
guess no need of versioned BuildRequires: and also Requires:


If this package needs versioned BR: and R: then please add comment in spec file

2) Guidelines suggests to keep timestamps of upstream installed files. So
please use 
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

3) Guidelines suggests package built above F-13 do not need %clean

See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

4) Guidelines recommends defattr usage as 
%defattr(-, root, root,-)
See https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions

5) rpmlint warned about non-utf8 file message so used http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8

6) Used current macros defined -> http://fedoraproject.org/wiki/Packaging:RPMMacros

7) tried to clean this spec as per /etc/rpmdevtools/spectemplate-lib.spec

8)  we don't want to provide private python extension libs

Comment 3 Parag AN(पराग) 2010-10-21 06:26:21 UTC
committed patch but removed filtering. As per guildelines, this is arch package and installs binary in /usr/bin and also have libs.

Comment 4 Parag AN(पराग) 2010-10-22 04:35:55 UTC
Committed the above patch and built in libxslt-1.1.26-4.fc15


Comment 5 Paul Howarth 2010-10-22 17:20:47 UTC
Created attachment 455147 [details]
More careful approach to charset conversion

tutorial2/libxslt_pipes.xml is explicitly iso-8859-2 encoded and shouldn't have been converted to UTF-8 using iconv.

Attached patch does the conversion of the other docs without iconv and is a more surgical approach.

Comment 6 Parag AN(पराग) 2010-10-25 04:23:21 UTC
Can you help me to get above patch updated for 1.1.26 release? this upstream release has been already available in all fedora branches.

So, we need not use iconv for xml files. Can we also need to convert NEWS to utf8?

Comment 7 Paul Howarth 2010-10-27 12:14:51 UTC
The patch applies cleanly against 1.1.26 and handles NEWS already.

Comment 8 Parag AN(पराग) 2010-10-27 15:53:09 UTC
Sorry and thanks. Patch is working fine. Actually I got some encoding issues on my machine that is why patch was not working.

Comment 9 Parag AN(पराग) 2010-10-28 05:40:37 UTC
Built in libxslt-1.1.26-5.fc15

Note You need to log in before you can comment on or make changes to this bug.