Review:
(CC'ing the people, who modified this recently.)

Good:
- name ok
- BR ok (pkgconfig is unneeded, but that doesn't matter here)
- %prep ok
- rpmlint:
libXxf86dga.src: W: invalid-url Source0: ftp://ftp.x.org/pub/individual/lib/libXxf86dga-1.1.1.tar.bz2 <urlopen error ftp error: timed out>
libXxf86dga.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, runtish
- %files ok
- license ok
- latest version packaged
- libs correctly packaged
- no locale files
- no *.la


Needswork:
- https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
- please use INSTALL="install -p", when installing
- libXxf86dga.x86_64: W: name-repeated-in-summary C libXxf86dga
  A slightly bigger description wouldn't hurt.
- libXxf86dga.src:51: W: macro-in-comment %doc -> should be %%doc
- %doc: There is also a README

___________________________________________________________________________


Not much to do, but not approving this now, because this is a merge review and not a normal package review...

(In reply to comment #1)
> Needswork:
> - https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
done
> - please use INSTALL="install -p", when installing
done

> - libXxf86dga.x86_64: W: name-repeated-in-summary C libXxf86dga
>   A slightly bigger description wouldn't hurt.

no, people may be tempted to use it then ;)

> - libXxf86dga.src:51: W: macro-in-comment %doc -> should be %%doc
removed

> - %doc: There is also a README

added.

> Not much to do, but not approving this now, because this is a merge review and
> not a normal package review...    

out of interest: the package has been around for ages, what would the formal approval really do?

(In reply to comment #2)
> (In reply to comment #1)
> > Needswork:
> > - https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
> done
> > - please use INSTALL="install -p", when installing
> done
> 
> > - libXxf86dga.x86_64: W: name-repeated-in-summary C libXxf86dga
> >   A slightly bigger description wouldn't hurt.
> 
> no, people may be tempted to use it then ;)

Heh, that's to risky.^^
 
> > - libXxf86dga.src:51: W: macro-in-comment %doc -> should be %%doc
> removed
> 
> > - %doc: There is also a README
> 
> added.

Thanks.
 
> > Not much to do, but not approving this now, because this is a merge review and
> > not a normal package review...    
> 
> out of interest: the package has been around for ages, what would the formal
> approval really do?    

The packages needing merge reviews used to be in Fedora Core and did not get any review yet. This makes sure, that they don't violate the guidelines (e.g. have a correct license and so on).
In this case it was more a cosmetic issue, but e.g. the python guidelines changed quite a lot, so python packages in the merge review queue will need more changes.
(That's the reason, why I started with xorg-x11-* ones ;-))

Also see (Don't know, why that's a draft...):
https://fedoraproject.org/wiki/Merge_Reviews
http://lists.fedoraproject.org/pipermail/devel/2010-July/138566.html