Bug 226098 - Merge Review: linuxdoc-tools
Summary: Merge Review: linuxdoc-tools
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Kamil Dudka
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2007-01-31 19:33 UTC by Nobody's working on this, feel free to take it
Modified: 2010-02-03 09:49 UTC (History)
2 users (show)

Fixed In Version: 0.9.66-5.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-02-03 09:49:48 UTC
Type: ---
kdudka: fedora-review+
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 19:33:58 UTC
Fedora Merge Review: linuxdoc-tools

Initial Owner: twaugh@redhat.com

Comment 1 Ondrej Vasik 2007-07-27 08:21:41 UTC
Package Change Request
Package Name: linuxdoc-tools
Updated Fedora Owners: ovasik@redhat.com

Comment 2 Kamil Dudka 2010-01-26 15:03:10 UTC
considered OK
- almost silent rpmlint (only one spelling false alarm)
- sane summary/description
- valid project URL and source URL
- upstream tarball is the same as the one from look-aside cache
- md5 hash matches the sources
- dist tag OK
- license tag OK
- BuildRoot tag OK
- %build OK
- %clean OK
- %defattr OK

may be better
- remove a redundant configure option --with-installed-nsgmls

- file doc/copyright is copy-pasted from iso-entities/COPYING, moreover the file is not used either

- it would be good to package also COPYING from the root of the tarball and all the referred documents from there:
    * sgmls-1.1/LICENSE
    * iso-entities/COPYING
    * entity-map/COPYING

- %post/%postun: the ambiguously looking chain of && and || may be replaced by an if/then/fi construction (and perhaps also decorated by a commented)

Comment 3 Ondrej Vasik 2010-02-02 13:17:43 UTC
Thanks for review. Configure option removed, doc/COPYRIGHT removed from spec file, COPYING file + references shipped now. This post/postun ambiguously looking chain is common style of registration in texlive, I'd prefer to keep it as it is. Same way used in e.g. texinfo, jadetex, passivetex, xmltex and other packages. One thing was recommended in texinfo review - to requires(post): and requires(postun): %{_bindir}/texconfig-sys , to ensure proper texconfig-sys style registration. Done this way - which also fixes this ambigously looking construction. Built as linuxdoc-tools-0.9.66-5.fc13.

Comment 4 Kamil Dudka 2010-02-02 14:45:15 UTC
Looks good to me.


Comment 5 Ondrej Vasik 2010-02-03 09:49:48 UTC

Note You need to log in before you can comment on or make changes to this bug.