Bug 226098 - Merge Review: linuxdoc-tools
Merge Review: linuxdoc-tools
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Kamil Dudka
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 14:33 EST by Nobody's working on this, feel free to take it
Modified: 2010-02-03 04:49 EST (History)
2 users (show)

See Also:
Fixed In Version: 0.9.66-5.fc13
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-02-03 04:49:48 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
kdudka: fedora‑review+
wtogami: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:33:58 EST
Fedora Merge Review: linuxdoc-tools

Initial Owner: twaugh@redhat.com
Comment 1 Ondrej Vasik 2007-07-27 04:21:41 EDT
Package Change Request
Package Name: linuxdoc-tools
Updated Fedora Owners: ovasik@redhat.com
Comment 2 Kamil Dudka 2010-01-26 10:03:10 EST
considered OK
- almost silent rpmlint (only one spelling false alarm)
- sane summary/description
- valid project URL and source URL
- upstream tarball is the same as the one from look-aside cache
- md5 hash matches the sources
- dist tag OK
- license tag OK
- BuildRoot tag OK
- %build OK
- %clean OK
- %defattr OK

may be better
- remove a redundant configure option --with-installed-nsgmls

- file doc/copyright is copy-pasted from iso-entities/COPYING, moreover the file is not used either

- it would be good to package also COPYING from the root of the tarball and all the referred documents from there:
    * sgmls-1.1/LICENSE
    * iso-entities/COPYING
    * entity-map/COPYING

- %post/%postun: the ambiguously looking chain of && and || may be replaced by an if/then/fi construction (and perhaps also decorated by a commented)
Comment 3 Ondrej Vasik 2010-02-02 08:17:43 EST
Thanks for review. Configure option removed, doc/COPYRIGHT removed from spec file, COPYING file + references shipped now. This post/postun ambiguously looking chain is common style of registration in texlive, I'd prefer to keep it as it is. Same way used in e.g. texinfo, jadetex, passivetex, xmltex and other packages. One thing was recommended in texinfo review - to requires(post): and requires(postun): %{_bindir}/texconfig-sys , to ensure proper texconfig-sys style registration. Done this way - which also fixes this ambigously looking construction. Built as linuxdoc-tools-0.9.66-5.fc13.
Comment 4 Kamil Dudka 2010-02-02 09:45:15 EST
Looks good to me.

Comment 5 Ondrej Vasik 2010-02-03 04:49:48 EST

Note You need to log in before you can comment on or make changes to this bug.