Fedora Merge Review: linuxdoc-tools http://cvs.fedora.redhat.com/viewcvs/devel/linuxdoc-tools/ Initial Owner: twaugh
Package Change Request ====================== Package Name: linuxdoc-tools Updated Fedora Owners: ovasik
considered OK ============= - almost silent rpmlint (only one spelling false alarm) - sane summary/description - valid project URL and source URL - upstream tarball is the same as the one from look-aside cache - md5 hash matches the sources - dist tag OK - license tag OK - BuildRoot tag OK - %build OK - %clean OK - %defattr OK may be better ============= - remove a redundant configure option --with-installed-nsgmls - file doc/copyright is copy-pasted from iso-entities/COPYING, moreover the file is not used either - it would be good to package also COPYING from the root of the tarball and all the referred documents from there: * sgmls-1.1/LICENSE * iso-entities/COPYING * entity-map/COPYING - %post/%postun: the ambiguously looking chain of && and || may be replaced by an if/then/fi construction (and perhaps also decorated by a commented)
Thanks for review. Configure option removed, doc/COPYRIGHT removed from spec file, COPYING file + references shipped now. This post/postun ambiguously looking chain is common style of registration in texlive, I'd prefer to keep it as it is. Same way used in e.g. texinfo, jadetex, passivetex, xmltex and other packages. One thing was recommended in texinfo review - to requires(post): and requires(postun): %{_bindir}/texconfig-sys , to ensure proper texconfig-sys style registration. Done this way - which also fixes this ambigously looking construction. Built as linuxdoc-tools-0.9.66-5.fc13.
Looks good to me. fedora-review+
Closing.