Red Hat Bugzilla – Bug 226106
Merge Review: lrzsz
Last modified: 2010-01-06 06:47:53 EST
Fedora Merge Review: lrzsz
Initial Owner: email@example.com
formal review of lrzsz-0.12.20-27.fc12 is here, see the notes below:
YES source files match upstream:
YES package meets naming and versioning guidelines.
YES specfile is properly named, is cleanly written and uses macros consistently.
YES dist tag is present.
YES build root is correct.
YES license field matches the actual license.
YES license is open source-compatible.
YES License text included in package.
YES latest version is being packaged.
YES BuildRequires are proper.
YES compiler flags are appropriate.
YES %clean is present.
YES package builds in mock (Rawhide/x86_64).
YES debuginfo package looks complete.
YES rpmlint is silent.
YES final provides and requires look sane.
YES %check is present and all tests pass.
YES no shared libraries are added to the regular linker search paths.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
YES file permissions are appropriate.
YES no scriptlets present.
YES code, not content.
YES documentation is small, so no -docs subpackage is necessary.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.
This package is APPROVED.
- YES %check is present and all tests pass.
+ N/A %check is present and all tests pass.
But still APPROVED :-)