Fedora Merge Review: lslk
Initial Owner: email@example.com
Created attachment 451705 [details]
This git patch clean this package for this review. Please commit this patch or allow to commit.
Committed, pushed to rawhide. THANKS!
oops! looks like my patch just added %doc but when I locally built this new package, missed to add them actually and thus rpmlint was clean.
With the new build rpmlint is complaining
lslk.x86_64: E: non-standard-executable-perm /usr/share/doc/lslk-1.29/Inventory 0555L
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.
lslk.x86_64: W: spurious-executable-perm /usr/share/doc/lslk-1.29/Inventory
The file is installed with executable permissions, but was identified as one
that probably should not be executable. Verify if the executable bits are
desired, and remove if not.
This can be fixed by adding following line in end of %prep section
chmod 644 Inventory
Can you please fix this?
(In reply to comment #3)
> This can be fixed by adding following line in end of %prep section
> chmod 644 Inventory
> Can you please fix this?
Thanks for quick fix.
APPROVED this review.