Red Hat Bugzilla – Bug 226114
Merge Review: m2crypto
Last modified: 2015-09-28 15:17:32 EDT
Fedora Merge Review: m2crypto
Initial Owner: email@example.com
! rpmlint checks return:
m2crypto.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/m2crypto-0.21.1/tests/thawte.pem
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.
Fix until that would break the tests.
m2crypto.x86_64: E: zero-length /usr/share/doc/m2crypto-0.21.1/demo/Zope/lib/python/Products/GuardedFile/refresh.txt
Ignore or remove.
! package meets naming guidelines Should really be python-m2crypto. If you submit a rename review I'll do it. Or this could be it, really.
- package meets packaging guidelines
! license ( MIT ) I see BSD-style, Apache 2.0, MIT, Zope Public License, should this not reflect all of those?
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
So just rpmlint, name and license, otherwise OK.
(In reply to comment #2)
I do appreciate the review, and I plan to act on it... however fixing other broken stuff is more important at the moment, I'm afraid.
Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket:
If you don't know what merge reviews are about, please see:
How to handle this bug is left to the discretion of the package maintainer.
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.
(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)
More information and reason for this action is here: