Fedora Merge Review: mailcap http://cvs.fedora.redhat.com/viewcvs/devel/mailcap/ Initial Owner: mlichvar
rpmlint: SRPM: mailcap.src:164: W: macro-in-%changelog variables Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. mailcap.src: W: no-url-tag The URL tag is missing. RPM: mailcap.noarch: W: no-url-tag The URL tag is missing. These are fixed by changing %variables in 164 to %%variables, and including a URL tag. Who is techincally upstream, Red Hat or Fedora?
See also bug 388481
Agreed.
Created attachment 290424 [details] Patch to correct macro in changelog.
mailcap currently doesn't have a home page. It will be moved to hosted.fedoraproject.org once there is a place to upload tarballs. In mailcap-2.1.26, the macro in changelog is escaped and there is a comment added how to create the tarball.
When will that be? Because everything else about this checks out, except for issues stemming from the lack of an "upstream", i.e. Source0 URL, URL tag, source MD5 check, etc. Those are the only blockers.
The packaging guidelines don't seem to require URL tag and for the source tag there is a comment explaining how to recreate the tarball from CVS, so I think it's ok to approve the package if there are no other issues.
Ok. works for me. APPROVED.