Fedora Merge Review: metacity http://cvs.fedora.redhat.com/viewcvs/devel/metacity/ Initial Owner: sandmann
Bad: - Local build failed: + cd metacity-2.18.0 + LANG=C + export LANG + unset DISPLAY + rm -rf /var/tmp/metacity-2.18.0-1-root-s4504kr + CPPFLAGS=' -I/var/tmp/metacity-2.18.0-1-root-s4504kr/usr/include' + export CPPFLAGS + autoreconf src/Makefile.am: required file `./compile' not found autoreconf: automake failed with exit status: 1 Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.46901 (%build)
* a remark the gettext_package, metacity_version and metacity_filename don't seem to be usefull to me, %{name}, %{version} and %{name}-%{version} would seem more natural to me * -I$RPM_BUILD_ROOT%{_includedir} seems wrong to me. Why is it there? CPPFLAGS="$CPPFLAGS -I$RPM_BUILD_ROOT%{_includedir}" * Why run autoreconf? * on the make line, CPPFLAGS="$CPPFLAGS" LIBS="$LIBS" seems unuseful to me, while %{?_smp_mflags} is missing (it worked in my tests) * The pkgconfig Requires is unuseful in main package
Ping?
I am happy enough for someone to just go ahead and fix these things. I don't believe metacity has any ACL's.
Created attachment 454045 [details] spec cleanup Please commit this git patch that will clean this package for this review or allow to commit.
Committed the above patch and built in metacity-2.30.3-2.fc15 APPROVED.