Fedora Merge Review: mingetty http://cvs.fedora.redhat.com/viewcvs/devel/mingetty/ Initial Owner: laroche
rpmlint output on SRPM: mingetty.src: W: summary-ended-with-dot A compact getty program for virtual consoles only. Summary ends with a dot. mingetty.src: W: invalid-license GPL The value of the License tag was not recognized. Known values are: "Adobe", "AFL", "AGPLv1", "AGPLv3", "AMPAS BSD", "ARL", "ASL 1.0", "ASL 1.0+", "ASL 1.1", "ASL 1.1+", "ASL 2.0", "ASL 2.0+", "APSL 2.0", "APSL 2.0+", "Artistic 2.0", "Artistic clarified", "BitTorrent", "Boost", "BSD", "BSD with advertising", "CeCILL", "CDDL", "CPL", "Condor", "Copyright only", "Cryptix", "Crystal Stacker", "EPL", "eCos", "EFL 2.0", "EFL 2.0+", "EU Datagrid", "FTL", "Giftware", "Glide", "gnuplot", "GPL+", "GPL+ or Artistic", "GPLv2+ or Artistic", "GPLv2", "GPLv2 with exceptions", "GPLv2+", "GPLv2+ with exceptions", "GPLv3", "GPLv3 with exceptions", "GPLv3+", "GPLv3+ with exceptions", "IBM", "IJG", "ImageMagick", "iMatix", "Imlib2", "Intel ACPI", "Interbase", "ISC", "Jabber", "JasPer", "LGPLv2", "LGPLv2 with exceptions", "LGPLv2+", "LGPLv3", "LGPLv3+", "libtiff", "LPL", "LPPL", "mecab-ipadic", "MIT", "MPLv1.0", "MPLv1.0+", "MPLv1.1", "MPLv1.1+", "NCSA", "NGPL", "NOSL", "Netscape", "Nokia", "OpenLDAP", "OpenPBS", "OReilly", "OSL 1.0", "OSL 1.0+", "OSL 1.1", "OSL 1.1+", "OSL 2.0", "OSL 2.0+", "OSL 3.0", "OSL 3.0+", "OpenSSL", "Phorum", "PHP", "Public Domain", "Python", "QPL", "RPSL", "Ruby", "Sleepycat", "SISSL", "SLIB", "SPL", "TCL", "UCD", "Vim", "VNLSL", "VSL", "W3C", "WTFPL", "wxWindows", "xinetd", "Zend", "ZPLv1.0", "ZPLv1.0+", "ZPLv2.0", "ZPLv2.0+", "ZPLv2.1", "ZPLv2.1+", "zlib", "CDL", "FBSDDL", "GFDL", "IEEE", "OFSFDL", "Open Publication", "CC-BY", "CC-BY-SA", "DSL", "Free Art", "Arphic", "Baekmuk", "Bitstream Vera", "mplus", "OFL", "STIX", "Utopia", "XANO", "Redistributable, no modification permitted", "Freely redistributable without restriction". mingetty.src: W: no-url-tag The URL tag is missing. Correct license tag is GPLv2+. Since URL tag is missing, and Red Hat is upstream, this should probably get space on hosted. rpmlint on RPMS have the same issues, plus: The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it. Just change * Tue Aug 21 2007 Florian La Roche <laroche> to * Tue Aug 21 2007 Florian La Roche <laroche> - 1.07-6 But then of course you'll need to update it again for the rebuild after the merge review. :)
Created attachment 290425 [details] Patch for all current issues, save the URL tag.
Current rpm package has the above patch applied plus also an url is now added. Thanks a lot for the review, Florian La Roche
You should not close the review before the reviewer has set the fedora review flag to +.
Indeed. I've just now finished the rest of the review, and there's another change to be made. The Source tag must include a URL, a la: Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz Fix that and I'll approve.
This is fixed now. Thanks for the review, Florian La Roche
Perfect. Thank you, and you're very welcome. APPROVED.