Hide Forgot
Fedora Merge Review: mod_python http://cvs.fedora.redhat.com/viewcvs/devel/mod_python/ Initial Owner: jorton@redhat.com
rpmlint output on SRPM and RPM gave mod_python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/mod_python/_psp.so _psp.so()(64bit) mod_python.x86_64: W: file-not-utf8 /usr/share/doc/mod_python-3.3.1/CREDITS mod_python.x86_64: W: file-not-utf8 /usr/share/doc/mod_python-3.3.1/NEWS mod_python.src:46: E: use-of-RPM_SOURCE_DIR mod_python.src:265: W: macro-in-%changelog %{contentdir}
Also, According to Python packaging guidelines you don't need python_sitearch macro and also should BR: python-devel Some recent guidelines changes suggests 1) buildroot should be removed 2) %clean not needed 3) cleaning of buildroot at start of %install also not needed
Created attachment 433583 [details] spec cleanup Good if you add dist tag to proposed changes in patch.
jorton ping
Looks Maintainer don't want to fix this after talking with him on IRC also. Let's push this to NEW.
Ok, Seems FESCo allowed now reviewer to commit changes. I will take this review again and commit the changes and close this review.
Committed patch. Built in mod_python-3.3.1-13 I have left using dist-tag to its maintainer as its not mandatory. Closing this review.
Thanks a lot, Parag!
Package Change Request ====================== Package Name: mod_python New Branches: el6 Owners: lkundrak mod_python was removed from el6 and Fedora maintainer (jorton) is not willing to maintain it as he considers the package dead given very low upstream development activity. I need the package for koji-{web,hub} thus I'm willing to maintain it in epel for el6, Joe does not object.
Git done (by process-git-requests).