Bug 226156 - Merge Review: mod_python
Merge Review: mod_python
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:42 EST by Nobody's working on this, feel free to take it
Modified: 2010-11-29 11:54 EST (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-09-06 01:09:33 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)
spec cleanup (2.48 KB, patch)
2010-07-22 01:15 EDT, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:42:41 EST
Fedora Merge Review: mod_python

http://cvs.fedora.redhat.com/viewcvs/devel/mod_python/
Initial Owner: jorton@redhat.com
Comment 1 Parag AN(पराग) 2010-07-20 06:41:13 EDT
rpmlint output on SRPM and RPM gave

mod_python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/mod_python/_psp.so _psp.so()(64bit)
mod_python.x86_64: W: file-not-utf8 /usr/share/doc/mod_python-3.3.1/CREDITS
mod_python.x86_64: W: file-not-utf8 /usr/share/doc/mod_python-3.3.1/NEWS
mod_python.src:46: E: use-of-RPM_SOURCE_DIR
mod_python.src:265: W: macro-in-%changelog %{contentdir}
Comment 2 Parag AN(पराग) 2010-07-22 01:15:04 EDT
Also,
According to Python packaging guidelines you don't need python_sitearch macro and also should BR: python-devel 

Some recent guidelines changes suggests
1) buildroot should be removed
2) %clean not needed
3) cleaning of buildroot at start of %install also not needed
Comment 3 Parag AN(पराग) 2010-07-22 01:15:52 EDT
Created attachment 433583 [details]
spec cleanup

Good if you add dist tag to proposed changes in patch.
Comment 4 Parag AN(पराग) 2010-08-02 11:07:02 EDT
jorton ping
Comment 5 Parag AN(पराग) 2010-08-09 05:25:28 EDT
jorton ping
Comment 6 Parag AN(पराग) 2010-08-11 00:26:07 EDT
Looks Maintainer don't want to fix this after talking with him on IRC also. Let's push this to NEW.
Comment 7 Parag AN(पराग) 2010-09-03 01:22:12 EDT
Ok, Seems FESCo allowed now reviewer to commit changes. I will take this review again and commit the changes and close this review.
Comment 8 Parag AN(पराग) 2010-09-06 01:09:33 EDT
Committed patch. Built in mod_python-3.3.1-13
I have left using dist-tag to its maintainer as its not mandatory.
Closing this review.
Comment 9 Joe Orton 2010-09-06 04:11:52 EDT
Thanks a lot, Parag!
Comment 10 Lubomir Rintel 2010-11-26 06:01:44 EST
Package Change Request
======================
Package Name: mod_python
New Branches: el6
Owners: lkundrak

mod_python was removed from el6 and Fedora maintainer (jorton) is not willing to maintain it as he considers the package dead given very low upstream development activity. I need the package for koji-{web,hub} thus I'm willing to maintain it in epel for el6, Joe does not object.
Comment 11 Jason Tibbitts 2010-11-29 11:54:57 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.