Red Hat Bugzilla – Bug 226165
Merge Review: mt-st
Last modified: 2009-12-02 06:05:55 EST
Fedora Merge Review: mt-st http://cvs.fedora.redhat.com/viewcvs/devel/mt-st/ Initial Owner: jnovy@redhat.com
Package Change Request ====================== Package Name: mt-st Updated Fedora Owners: rbrich@redhat.com
Agreed with ownership transition.
canceling request, it's now ok (via pkgdb)
Review follows: OK source files match upstream: fdd5f5ec673c9f630a102ceff7612774 mt-st-1.1.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock. OK debuginfo package looks complete. NO rpmlint is silent. mt-st.x86_64: W: service-default-enabled /etc/rc.d/init.d/stinit mt-st.x86_64: E: no-status-entry /etc/rc.d/init.d/stinit mt-st.x86_64: W: no-reload-entry /etc/rc.d/init.d/stinit mt-st.x86_64: E: subsys-not-used /etc/rc.d/init.d/stinit mt-st.x86_64: W: incoherent-init-script-name stinit ('mt-st', 'mt-std') Enabled by default and incoherent name are ok, but the script should be probably updated to match the Fedora init script guidelines. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK scriptlets are sane. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app.
The stinit initscript was recently updated in F-12 and rawhide (see bug 541592 for details) and it doesn't start any daemon, but it does only a one-time initialization of tape devices, so I think it can live as it is.
Ok, thanks. The package is APPROVED.