Bug 2262025 - Review Request: rust-sval_nested - Recursive variant of sval
Summary: Review Request: rust-sval_nested - Recursive variant of sval
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/sval_nested
Whiteboard:
Depends On:
Blocks: 2256402
TreeView+ depends on / blocked
 
Reported: 2024-01-30 23:25 UTC by Fabio Valentini
Modified: 2024-02-24 22:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-24 22:26:09 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6974721 to 6980073 (639 bytes, patch)
2024-02-01 17:03 UTC, Fedora Review Service
no flags Details | Diff

Description Fabio Valentini 2024-01-30 23:25:17 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-sval_nested.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-sval_nested-2.11.0-1.fc39.src.rpm

Description:
A recursive variant of sval.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2024-01-30 23:27:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6974721
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262025-rust-sval_nested/fedora-rawhide-x86_64/06974721-rust-sval_nested/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-30 23:28:11 UTC
This package is a dependency for - and depends on - other updates for sval* and value-bag* Rust crates.
These can only be submitted as one big update to avoid broken dependencies.

I'm building everything in COPR so this package can still be reviewed:
https://copr.fedorainfracloud.org/coprs/decathorpe/sval-2.11-value-bag-1.6/monitor/

Comment 3 Fabio Valentini 2024-01-30 23:29:36 UTC
The place where this package fits into the dependency graph of the existing rust-sval* and rust-value-bag* packages can be seen here:
https://hackmd.io/@decathorpe/FedoraRustPackageGraphs#sval--value-bag

Comment 4 Fabio Valentini 2024-02-01 16:59:59 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-sval_nested.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-sval_nested-2.11.1-1.fc39.src.rpm

Updated to version 2.11.1 and drop the patch from 2.11.0 that was accepted upstream.

Comment 5 Fedora Review Service 2024-02-01 17:03:46 UTC
Created attachment 2014408 [details]
The .spec file difference from Copr build 6974721 to 6980073

Comment 6 Fedora Review Service 2024-02-01 17:03:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6980073
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262025-rust-sval_nested/fedora-rawhide-x86_64/06980073-rust-sval_nested/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Michel Lind 2024-02-22 23:46:26 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide (with the COPR enabled)
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Fabio Valentini 2024-02-24 18:13:48 UTC
Thank you for the review!

Comment 9 Fedora Admin user for bugzilla script actions 2024-02-24 18:15:43 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sval_nested

Comment 10 Fedora Update System 2024-02-24 22:18:31 UTC
FEDORA-2024-24c6fe88b7 (rust-sval-2.11.1-1.fc41, rust-sval_buffer-2.11.1-1.fc41, and 13 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-24c6fe88b7

Comment 11 Fedora Update System 2024-02-24 22:26:09 UTC
FEDORA-2024-24c6fe88b7 (rust-sval-2.11.1-1.fc41, rust-sval_buffer-2.11.1-1.fc41, and 13 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.