Red Hat Bugzilla – Bug 226217
Merge Review: opensp
Last modified: 2008-10-24 03:25:15 EDT
Fedora Merge Review: opensp
Initial Owner: email@example.com
Package Change Request
Package Name: opensp
Updated Fedora Owners: firstname.lastname@example.org
The package is in a good shape, the only things I think should be done are:
- Drop *.la,
- License: MIT instead of BSD, and
- %check comments could be updated.
Will attach a patch.
Created attachment 321176 [details]
Drop *.la, fix License tag, update comments
Thanks for review...
Ok with droping .la and comments, but about license I have a question - as upstream has BSD license on http://sourceforge.net/projects/openjade/ URL page. How you got the feeling that MIT is more suitable for OpenSP?
Yes, I think upstream's sf.net License category is a bit inaccurate. Compare COPYING in the OpenSP tarball with https://fedoraproject.org/wiki/Licensing/MIT and https://fedoraproject.org/wiki/Licensing/BSD
Ok, looks exactly as Modern Style of MIT ... therefore will use MIT, thanks for explanation. Built in Rawhide as opensp-1.5.2-8.fc10.
One remaining cosmetic thing I noticed but failed to note in previous comments:
$ rpmlint -i opensp-1.5.2-8.fc9.x86_64.rpm
opensp.x86_64: W: file-not-utf8 /usr/share/doc/opensp-1.5.2/ChangeLog
The character encoding of this file is not UTF-8. Consider converting it in
the specfile for example using iconv(1).
Not at all a blocker but would be nice to get it fixed nevertheless. Setting approved already, feel free to close when you've looked into it.
Fixed in opensp-1.5.2-9.fc10, I will ignore last remaining rpmlint warning about missing doc files in opensp-devel subpackage as the documentation is in main opensp package. Closing RAWHIDE, thanks again for review.
The conversion should not be done in %build because that will result it being done multiple times and thus in corrupted result when doing multiple successive --short-circuit builds. %prep would be the proper place to do it (I'll update rpmlint's message to reflect that).
Also, there's little reason to convert HTML files that have the correct encoding in their meta info - HTML files are opened with browsers that should grok the encoding just fine. This is the reason why rpmlint does not complain about HTML (and some other) files' encodings even when they're not UTF-8.
Thanks, ok, have to upgrade my rpmlint, because my version complained about ".html" file as well - and because it was created at build time, I used iconv in build section. Will move it to prep again without releasenotes.html conversion.