Bug 226226 - Merge Review: pam_passwdqc
Merge Review: pam_passwdqc
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:19 EST by Nobody's working on this, feel free to take it
Modified: 2010-09-06 04:17 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-09-06 04:17:47 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)
pam_passwdqc-spec-cleanup.patch (1.76 KB, patch)
2010-07-24 09:42 EDT, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:19:58 EST
Fedora Merge Review: pam_passwdqc

http://cvs.fedora.redhat.com/viewcvs/devel/pam_passwdqc/
Initial Owner: nalin@redhat.com
Comment 1 Parag AN(पराग) 2010-07-24 09:40:15 EDT
1) rpmlint reported
pam_passwdqc.src: W: spelling-error Summary(en_US) Pluggable -> Plug gable, Plug-gable, Plugged
pam_passwdqc.src: W: spelling-error %description -l en_US pam -> map, Pam, pan
pam_passwdqc.src: W: spelling-error %description -l en_US passwdqc -> password, passageway, passivised
pam_passwdqc.src: W: spelling-error %description -l en_US passwd -> passed
pam_passwdqc.src: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases
pam_passwdqc.i686: W: spelling-error Summary(en_US) Pluggable -> Plug gable, Plug-gable, Plugged
pam_passwdqc.i686: W: spelling-error %description -l en_US pam -> map, Pam, pan
pam_passwdqc.i686: W: spelling-error %description -l en_US passwdqc -> password, passageway, passivised
pam_passwdqc.i686: W: spelling-error %description -l en_US passwd -> passed
pam_passwdqc.i686: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases
==> This can be ignored.

2)timestamps should be preserved.Use INSTALL="install -p" when installing to
preserve timestamps.

3) I will suggest this pacakge to follow current packaging guidelines and
remove buildroot, %clean section and cleaning of build root in %install    

4) Should follow https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
Comment 2 Parag AN(पराग) 2010-07-24 09:42:15 EDT
Created attachment 434142 [details]
pam_passwdqc-spec-cleanup.patch

please add changelog entry when applying above patch in devel branch
Comment 3 Parag AN(पराग) 2010-07-24 10:26:21 EDT
Also,
 As per https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags , please add comment in spec why you need extras flags.
Comment 4 Parag AN(पराग) 2010-08-02 11:07:51 EDT
ping
Comment 5 Avesh Agarwal 2010-08-02 11:12:46 EDT
I am looking into these. will get back to you soon.
Comment 6 Avesh Agarwal 2010-08-03 12:32:32 EDT
I verified the patch as per fedora guidelines, and it seems fine. I have also added the explanation for the extra C flags, and changelog entry too. Right now I can not commit to F14 (seems frozen), otherwise will make a new build soon based on the patch. Thanks for the patch.
Comment 8 Parag AN(पराग) 2010-08-09 01:07:03 EDT
Looks good now.
After you build this updated srpm in rawhide, I will approve this review.
Comment 9 Parag AN(पराग) 2010-09-06 04:17:47 EDT
Thanks! I see you have updated srpm in rawhide.

APPROVED.

Note You need to log in before you can comment on or make changes to this bug.