Hide Forgot
Fedora Merge Review: pam_passwdqc http://cvs.fedora.redhat.com/viewcvs/devel/pam_passwdqc/ Initial Owner: nalin@redhat.com
1) rpmlint reported pam_passwdqc.src: W: spelling-error Summary(en_US) Pluggable -> Plug gable, Plug-gable, Plugged pam_passwdqc.src: W: spelling-error %description -l en_US pam -> map, Pam, pan pam_passwdqc.src: W: spelling-error %description -l en_US passwdqc -> password, passageway, passivised pam_passwdqc.src: W: spelling-error %description -l en_US passwd -> passed pam_passwdqc.src: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases pam_passwdqc.i686: W: spelling-error Summary(en_US) Pluggable -> Plug gable, Plug-gable, Plugged pam_passwdqc.i686: W: spelling-error %description -l en_US pam -> map, Pam, pan pam_passwdqc.i686: W: spelling-error %description -l en_US passwdqc -> password, passageway, passivised pam_passwdqc.i686: W: spelling-error %description -l en_US passwd -> passed pam_passwdqc.i686: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases ==> This can be ignored. 2)timestamps should be preserved.Use INSTALL="install -p" when installing to preserve timestamps. 3) I will suggest this pacakge to follow current packaging guidelines and remove buildroot, %clean section and cleaning of build root in %install 4) Should follow https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
Created attachment 434142 [details] pam_passwdqc-spec-cleanup.patch please add changelog entry when applying above patch in devel branch
Also, As per https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags , please add comment in spec why you need extras flags.
ping
I am looking into these. will get back to you soon.
I verified the patch as per fedora guidelines, and it seems fine. I have also added the explanation for the extra C flags, and changelog entry too. Right now I can not commit to F14 (seems frozen), otherwise will make a new build soon based on the patch. Thanks for the patch.
Updated srpm is here: http://people.redhat.com/avagarwa/files/pam_passwdqc/pam_passwdqc-1.0.5-7.fc14.src.rpm
Looks good now. After you build this updated srpm in rawhide, I will approve this review.
Thanks! I see you have updated srpm in rawhide. APPROVED.