Fedora Merge Review: pam_smb http://cvs.fedora.redhat.com/viewcvs/devel/pam_smb/ Initial Owner: nalin
1) rpmlint reported pam_smb.src: W: summary-ended-with-dot C A Pluggable Authentication Module (PAM) for use with SMB servers. pam_smb.src: W: spelling-error %description -l en_US pam -> map, Pam, pan pam_smb.src: W: spelling-error %description -l en_US smb -> sob, sub, Sm pam_smb.i686: W: summary-ended-with-dot C A Pluggable Authentication Module (PAM) for use with SMB servers. pam_smb.i686: W: spelling-error %description -l en_US pam -> map, Pam, pan pam_smb.i686: W: spelling-error %description -l en_US smb -> sob, sub, Sm 2 packages and 0 specfiles checked; 0 errors, 6 warnings. ==> Fix needed for summary and rest can be ignored. 2)timestamps should be preserved.Use "install -p" when installing to preserve timestamps. 3) I will suggest this package to follow current packaging guidelines and remove buildroot, %clean section and cleaning of build root in %install 4) Buildroot is wrong and not needed now
Created attachment 434150 [details] pam_smb-spec-cleanup.patch add changelog entry
ssorce ping
ssorce ping otherwise I will commit the patch and close this review.
Please proceed.
Thanks. Built in pam_smb-1.1.7-12.fc15 closed.