Bug 226227 - Merge Review: pam_smb
Merge Review: pam_smb
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:20 EST by Nobody's working on this, feel free to take it
Modified: 2010-09-08 01:17 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-09-08 01:17:09 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)
pam_smb-spec-cleanup.patch (1.21 KB, patch)
2010-07-24 10:36 EDT, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:20:13 EST
Fedora Merge Review: pam_smb

http://cvs.fedora.redhat.com/viewcvs/devel/pam_smb/
Initial Owner: nalin@redhat.com
Comment 1 Parag AN(पराग) 2010-07-24 10:35:49 EDT
1) rpmlint reported
pam_smb.src: W: summary-ended-with-dot C A Pluggable Authentication Module (PAM) for use with SMB servers.
pam_smb.src: W: spelling-error %description -l en_US pam -> map, Pam, pan
pam_smb.src: W: spelling-error %description -l en_US smb -> sob, sub, Sm
pam_smb.i686: W: summary-ended-with-dot C A Pluggable Authentication Module (PAM) for use with SMB servers.
pam_smb.i686: W: spelling-error %description -l en_US pam -> map, Pam, pan
pam_smb.i686: W: spelling-error %description -l en_US smb -> sob, sub, Sm
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
==> Fix needed for summary and rest can be ignored.

2)timestamps should be preserved.Use "install -p" when installing to
preserve timestamps.

3) I will suggest this package to follow current packaging guidelines and
remove buildroot, %clean section and cleaning of build root in %install    

4) Buildroot is wrong and not needed now
Comment 2 Parag AN(पराग) 2010-07-24 10:36:41 EDT
Created attachment 434150 [details]
pam_smb-spec-cleanup.patch

add changelog entry
Comment 3 Parag AN(पराग) 2010-08-02 11:08:24 EDT
ssorce ping
Comment 4 Parag AN(पराग) 2010-08-09 00:59:49 EDT
ssorce ping
Comment 5 Parag AN(पराग) 2010-09-07 10:48:58 EDT
ssorce ping otherwise I will commit the patch and close this review.
Comment 6 Simo Sorce 2010-09-07 11:28:22 EDT
Please proceed.
Comment 7 Parag AN(पराग) 2010-09-08 01:17:09 EDT
Thanks. Built in pam_smb-1.1.7-12.fc15 closed.

Note You need to log in before you can comment on or make changes to this bug.