BLOCKER:
  MUST: The License field in the package spec file must match the actual license.

The license is actually more complicated than the LGPL that the spec file
currently says. See bug 224135.

So, "LGPL plus/minus exception"?

(In reply to comment #2)
> So, "LGPL plus/minus exception"?

"LGPL with additional restrictions", I think. The additional restrictions would
be whatever FTL/GPL would impose.

Bad news! <http://fedoraproject.org/wiki/Packaging/Guidelines#Legal> says that
the license must be in one of the three lists. Since FTL is nowhere on those
lists, unless FSF reviews it or OSI approves it, we may need to consider pango
and freetype GPL.

We're kinda out of it: 2 of 3 FreeType developers have agreed to changing the
GPL+FTL to LGPL+FTL for HarfBuzz.

This has happened by the way.  We've gone with the Old MIT license which doesn't have any advertising requirement.

The license and the license field have long been fixed.  Closing.

package has not been reviewed and approved.  you cant close it until review is complete.

1) rpmlint reported

pango.src: W: spelling-error %description -l en_US backends -> backbends, back ends, back-ends
pango.src:505: W: macro-in-%changelog %{version}
pango.src:505: W: macro-in-%changelog %{release}
pango.src: W: no-cleaning-of-buildroot %clean
pango.src: W: no-buildroot-tag
pango.src: W: no-%clean-section
pango.src:83: W: mixed-use-of-spaces-and-tabs (spaces: line 82, tab: line 83)
pango.x86_64: W: spelling-error %description -l en_US backends -> backbends, back ends, back-ends
pango.x86_64: W: conffile-without-noreplace-flag /etc/pango/pangox.aliases
pango.x86_64: W: no-manual-page-for-binary pango-querymodules-64
3 packages and 0 specfiles checked; 0 errors, 10 warnings.

2)also build.log from latest build on koji showed
warning: File listed twice: /usr/share/man/man1/pango-view.1.gz

3)this package should follow https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

4)this package should follow https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

Created attachment 433083 [details]
pango spec cleanup

Also, scratch build with this patch applied is successful
http://koji.fedoraproject.org/koji/taskinfo?taskID=2330361

to above patch Changelog entry need to be added.

mclasen,
  Can you please help to complete this review by applying above patch?

Thanks.

ping behdad or mclasen,
  Can anyone please update this package for its merge-review?

After repetitive pings on bz, looking into discussion happened in yesterday's FESCo meeting where X/Desktop team members almost shown un-willingness to fix this review, I am pushing back this to NEW queue.

not sure what you are talking about. the changes in your patch certainly don't look like they are worth loosing more than 5 minutes about. Feel free to commit it.

FYI, http://lists.fedoraproject.org/pipermail/packaging/2010-August/007316.html

(In reply to comment #14)
> not sure what you are talking about. the changes in your patch certainly don't
> look like they are worth loosing more than 5 minutes about. Feel free to commit
> it.

Thanks. I will build new pango-1.28.1-5.fc15 in rawhide by applying above patch and close this review.

I have built above approved changes in rawhide. Closing this review now.