Bug 2262293 - Review Request: rust-rust_decimal_macros - Shorthand macros to assist creating Decimal types
Summary: Review Request: rust-rust_decimal_macros - Shorthand macros to assist creatin...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/rust_decimal...
Whiteboard:
Depends On:
Blocks: 2262142
TreeView+ depends on / blocked
 
Reported: 2024-02-01 15:55 UTC by Fabio Valentini
Modified: 2024-02-19 20:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-19 20:23:56 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-02-01 15:55:16 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-rust_decimal_macros.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-rust_decimal_macros-1.34.0-1.fc39.src.rpm

Description:
Shorthand macros to assist creating Decimal types.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-02-01 15:55:18 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=112740821

Comment 2 Fedora Review Service 2024-02-01 16:03:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6979847
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262293-rust-rust_decimal_macros/fedora-rawhide-x86_64/06979847-rust-rust_decimal_macros/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2024-02-19 19:14:21 UTC
Taking this review

Comment 4 Davide Cavalca 2024-02-19 19:17:22 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- please update to the latest version (1.34.2) before importing
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Fabio Valentini 2024-02-19 19:31:20 UTC
Thanks for the review!

Comment 6 Fedora Admin user for bugzilla script actions 2024-02-19 19:32:17 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rust_decimal_macros

Comment 7 Fedora Update System 2024-02-19 20:20:30 UTC
FEDORA-2024-bfbcbbfd9b (rust-rust_decimal-1.34.3-1.fc41 and rust-rust_decimal_macros-1.34.2-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-bfbcbbfd9b

Comment 8 Fedora Update System 2024-02-19 20:23:56 UTC
FEDORA-2024-bfbcbbfd9b (rust-rust_decimal-1.34.3-1.fc41 and rust-rust_decimal_macros-1.34.2-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.