Bug 2262303 - lprint-1.3.1 is available
Summary: lprint-1.3.1 is available
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: lprint
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zdenek Dohnal
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-01 17:05 UTC by Upstream Release Monitoring
Modified: 2024-07-26 03:15 UTC (History)
3 users (show)

Fixed In Version: lprint-1.3.1-1.fc40 lprint-1.3.1-1.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-07-26 01:21:44 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Upstream Release Monitoring 2024-02-01 17:05:58 UTC
Releases retrieved: 1.3.0
Upstream release that is considered latest: 1.3.0
Current version/release in rawhide: 1.2.0-6.fc40
URL: https://www.msweet.org/lprint/index.html

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://docs.fedoraproject.org/en-US/package-maintainers/Upstream_Release_Monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from Anitya: https://release-monitoring.org/project/125628/


To change the monitoring settings for the project, please visit:
https://src.fedoraproject.org/rpms/lprint

Comment 1 Upstream Release Monitoring 2024-02-10 12:00:52 UTC
Releases retrieved: 1.3.1
Upstream release that is considered latest: 1.3.1
Current version/release in rawhide: 1.2.0-6.fc40
URL: https://www.msweet.org/lprint/index.html

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://docs.fedoraproject.org/en-US/package-maintainers/Upstream_Release_Monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from Anitya: https://release-monitoring.org/project/125628/


To change the monitoring settings for the project, please visit:
https://src.fedoraproject.org/rpms/lprint

Comment 2 Pavel Roskin 2024-02-17 08:10:03 UTC
I've been using lprint 1.3.1 compiled by `fedpkg local` for some time. It's working well on Fedora 39. It would be great to have an official package.

Please note that local monochrome printing may not work without fixes to libcupsfilters made after version 2.0.0. Still, remote printing from other OSes should work.

Another issue is that lprint listens to port 8000 for all IPv4 addresses. Perhaps Fedora maintainers should work with the upstream to use a registered port and to limit access to localhost by default.

Comment 3 Zdenek Dohnal 2024-02-19 16:55:24 UTC
Hi Pavel,

I have lprint prepared locally as well, but I have found some issues which I would like to have fixed and some features which should be enabled now by default:

https://github.com/michaelrsweet/lprint/pull/128
https://github.com/michaelrsweet/pappl/pull/342

(In reply to Pavel Roskin from comment #2)
> Please note that local monochrome printing may not work without fixes to
> libcupsfilters made after version 2.0.0. Still, remote printing from other
> OSes should work.

Ok, I forgot to backport it from upstream, neither my fix or Till's, my bad :( - as I switch between several projects, I sometimes miss backporting fixes :) .

> 
> Another issue is that lprint listens to port 8000 for all IPv4 addresses.
> Perhaps Fedora maintainers should work with the upstream to use a registered
> port and to limit access to localhost by default.

At the moment I don't see an issue with port (destinations are all available via 'cupsGetDests() and friends' API), but you can present it to Mike upstream.

But what I'm working on at the moment is limiting the access to localhost - I've tried listen-hostname/server-hostname, but it looks there is a bug.

I have 'rebase-1.3.1' branch on my fork, if you are interested.

Comment 4 Pavel Roskin 2024-02-21 06:49:57 UTC
It's good to know that the lprint update is not forgotten. Listening to all interfaces is clearly a concern.

Thank you for backporting the libcupsfilters fixes!

You might want to update the dependencies. Most of them are unnecessary or implied. That's the minimum set that works from f38 to f41. Note the updated cups and pappl versions. CUPS is used through pkgconfig now.

# uses CUPS API for arrays, options, rastering, HTTP, IPP support
BuildRequires: pkgconfig(cups) >= 2.4.0
# written in C
BuildRequires: gcc
# for autosetup
BuildRequires: git-core
# the basic printer application related structures are now implemented in PAPPL
BuildRequires: pkgconfig(pappl) >= 1.2
# for macros in rpm scriptlets
BuildRequires: systemd-rpm-macros

The comment about systemd was quite poor. There is no dependency on systemd. /usr/lib/systemd/system/ is not part of the package, but /usr/lib/systemd/system/lprint.service is, as expected.

Another useful change to avoid listing all manpages. The lprint-options manual was added recently.

%files
%doc README.md DOCUMENTATION.md CONTRIBUTING.md CHANGES.md
%license LICENSE NOTICE
%{_bindir}/lprint
%{_mandir}/man1/lprint*.1*
%{_mandir}/man5/lprint*.5*
%{_unitdir}/lprint.service

Comment 5 Zdenek Dohnal 2024-02-21 15:32:55 UTC
(In reply to Pavel Roskin from comment #4)
> Thank you for backporting the libcupsfilters fixes!
> 
> You might want to update the dependencies. Most of them are unnecessary or
> implied.

Implied dependencies are common cause of issues, if the package requires it directly - but fortunately most of them are now provided in pappl (lprint was earlier without pappl, thus it had more dependencies, and I forgot to remove them later). If the package uses it, we should set BuildRequires/Requires on it if the dep is not generated during build - I wouldn't count on some tools being in buildroot or being provided by another require/buildrequire.

> That's the minimum set that works from f38 to f41. Note the updated
> cups and pappl versions. CUPS is used through pkgconfig now.
> 
> # uses CUPS API for arrays, options, rastering, HTTP, IPP support
> BuildRequires: pkgconfig(cups) >= 2.4.0
> # written in C
> BuildRequires: gcc
> # for autosetup
> BuildRequires: git-core
> # the basic printer application related structures are now implemented in
> PAPPL
> BuildRequires: pkgconfig(pappl) >= 1.2
> # for macros in rpm scriptlets
> BuildRequires: systemd-rpm-macros
> 
> The comment about systemd was quite poor. There is no dependency on systemd.
> /usr/lib/systemd/system/ is not part of the package, but
> /usr/lib/systemd/system/lprint.service is, as expected.

AFAIK every file and directory used during build or installation should be owned by the package or brought by a dependency. lprint puts lprint.service into /usr/lib/systemd/system, so it should own the dir, or require a package which provides the dir. Previously I used systemd since it provided the directory, but later found out filesystem does the trick.

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function (last paragraph of the point)

> 
> Another useful change to avoid listing all manpages.

This is discouraged by FPG https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists . And tbh, binaries and man pages are interesting to me, so I would like to see what is shipped.

> The lprint-options
> manual was added recently.

This is added in the branch I mentioned before.

But thanks for BuildRequires - I forgot to change this after lprint started used pappl. I committed it into my fork, where I prepare the release.

Comment 6 Fedora Update System 2024-07-17 13:06:27 UTC
FEDORA-2024-1028f53c17 (lprint-1.3.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1028f53c17

Comment 7 Fedora Update System 2024-07-17 13:18:42 UTC
FEDORA-2024-bdc624e551 (lprint-1.3.1-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-bdc624e551

Comment 8 Fedora Update System 2024-07-18 04:13:40 UTC
FEDORA-2024-bdc624e551 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-bdc624e551`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-bdc624e551

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-07-18 04:58:55 UTC
FEDORA-2024-1028f53c17 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1028f53c17`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1028f53c17

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-07-26 01:21:44 UTC
FEDORA-2024-1028f53c17 (lprint-1.3.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2024-07-26 03:15:43 UTC
FEDORA-2024-bdc624e551 (lprint-1.3.1-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.