Bug 226235 – Merge Review: pax

Bug 226235 - Merge Review: pax

Summary:	Merge Review: pax

Status:	CLOSED RAWHIDE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	Package Review (Show other bugs)
Sub Component:
Version:	rawhide
Hardware:	All Linux

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Orcan Ogetbil
QA Contact:	Fedora Package Reviews List
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2007-01-31 15:21 EST by Nobody's working on this, feel free to take it
Modified:	2009-01-31 00:32 EST (History)
CC List:	2 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2009-01-31 00:32:32 EST
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	oget.fedora: fedora‑review+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Nobody's working on this, feel free to take it 2007-01-31 15:21:32 EST

Fedora Merge Review: pax

http://cvs.fedora.redhat.com/viewcvs/devel/pax/
Initial Owner: pvrabec@redhat.com

Comment 1 Orcan Ogetbil 2008-11-20 01:50:31 EST

I reviewed this package. Here is what needs to be done for compliance with the guidelines:

* The doc files ABOUT-NLS, AUTHORS, ChangeLog, COPYING, NEWS, README, THANKS need to be packaged.

* We prefer %defattr(-,root,root,-)

* Buildroot must be one of these:
   %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
   %{_tmppath}/%{name}-%{version}-%{release}-root

* It would be nice if you explain in the SPEC file what the patches do. The project seems dead, I don't think there is any place to submit the patches to.

* Parallel make should be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment.

Comment 2 Orcan Ogetbil 2008-12-21 05:11:31 EST

ping?

Comment 3 Peter Vrabec 2009-01-19 05:55:31 EST

I'm removing myself from CC and adding ovasik. He is current maintainer of pax, according to:
https://admin.fedoraproject.org/pkgdb/packages/name/pax

Comment 4 Ondrej Vasik 2009-01-19 06:29:48 EST

Thanks for review. Afaik buildroot is completely ignored by latest rpm, so that guideline is no longer so important. Anyway - it is one commit, so could be fixed as well for sanity. I fixed all your objections, built as pax-3.4-7.fc11.

Comment 5 Orcan Ogetbil 2009-01-19 08:42:35 EST

You are welcome Ondrej. There is one more thing that I missed last time. The guidelines state that:
"Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} works." [1]

For pax, this really doesn't matter much since %makeinstall just works as desired. But it is stated in the above guideline as a "MUST" so I had to bring it into your attention.


Otherwise, I couldn't find any problems. Review is done on my side.

-------------------------------------------
This Merge Review (pax) is APPROVED by oget
-------------------------------------------


[1] http://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

Comment 6 Orcan Ogetbil 2009-01-31 00:32:32 EST

closing the bug

Note You need to log in before you can comment on or make changes to this bug.