Hide Forgot
Fedora Merge Review: pax http://cvs.fedora.redhat.com/viewcvs/devel/pax/ Initial Owner: pvrabec@redhat.com
I reviewed this package. Here is what needs to be done for compliance with the guidelines: * The doc files ABOUT-NLS, AUTHORS, ChangeLog, COPYING, NEWS, README, THANKS need to be packaged. * We prefer %defattr(-,root,root,-) * Buildroot must be one of these: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %{_tmppath}/%{name}-%{version}-%{release}-root * It would be nice if you explain in the SPEC file what the patches do. The project seems dead, I don't think there is any place to submit the patches to. * Parallel make should be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment.
ping?
I'm removing myself from CC and adding ovasik. He is current maintainer of pax, according to: https://admin.fedoraproject.org/pkgdb/packages/name/pax
Thanks for review. Afaik buildroot is completely ignored by latest rpm, so that guideline is no longer so important. Anyway - it is one commit, so could be fixed as well for sanity. I fixed all your objections, built as pax-3.4-7.fc11.
You are welcome Ondrej. There is one more thing that I missed last time. The guidelines state that: "Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} works." [1] For pax, this really doesn't matter much since %makeinstall just works as desired. But it is stated in the above guideline as a "MUST" so I had to bring it into your attention. Otherwise, I couldn't find any problems. Review is done on my side. ------------------------------------------- This Merge Review (pax) is APPROVED by oget ------------------------------------------- [1] http://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
closing the bug