Bug 226236 - Merge Review: pciutils
Merge Review: pciutils
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks: F9MergeReviewTarget
  Show dependency treegraph
 
Reported: 2007-01-31 15:21 EST by Nobody's working on this, feel free to take it
Modified: 2008-01-22 12:02 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-18 07:24:41 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
panemade: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:21:37 EST
Fedora Merge Review: pciutils

http://cvs.fedora.redhat.com/viewcvs/devel/pciutils/
Initial Owner: harald@redhat.com
Comment 1 Parag AN(पराग) 2007-11-30 06:35:03 EST
The only thing I see missing is keeping timestamps
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab

Otherwise packaging looks ok to me.
rpmlint is silent.
Thought static library should be in -static package but its not good to have
-static for single file.
Comment 2 Parag AN(पराग) 2007-11-30 06:52:05 EST
ohh. Missing some -devel things here
- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).

Also, is following needed here?
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 
Comment 3 Parag AN(पराग) 2007-12-18 09:08:55 EST
Are the required changes in CVS?
Comment 4 Parag AN(पराग) 2008-01-10 01:58:45 EST
ping
Comment 5 Harald Hoyer 2008-01-10 07:00:38 EST
fixed in rawhide
Comment 6 Parag AN(पराग) 2008-01-11 07:31:40 EST
here is new review now
1) Should follow packaging guideline for timestamp
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab

2) Do pciutils really need to install static library. Can we stop providing
static library /usr/lib/libpci.a
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

Comment 7 Parag AN(पराग) 2008-01-16 21:49:17 EST
ping?
Comment 8 Harald Hoyer 2008-01-18 04:09:47 EST
pong, rawhide pciutils-2.2.9-3.fc9
Comment 9 Parag AN(पराग) 2008-01-18 07:24:41 EST
Thanks.
APPROVED
Comment 10 Bill Nottingham 2008-01-22 12:02:28 EST
Reverting part of it. (In reply to comment #6)
> 2) Do pciutils really need to install static library. Can we stop providing
> static library /usr/lib/libpci.a

For future reference, 'repoquery --whatrequires pciutils-devel --repoid
development-source --archlist src' would answer this. library put back in rawhide.

Note You need to log in before you can comment on or make changes to this bug.