The only thing I see missing is keeping timestamps
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab

Otherwise packaging looks ok to me.
rpmlint is silent.
Thought static library should be in -static package but its not good to have
-static for single file.

ohh. Missing some -devel things here
- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).

Also, is following needed here?
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 

Are the required changes in CVS?

ping

fixed in rawhide

here is new review now
1) Should follow packaging guideline for timestamp
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab

2) Do pciutils really need to install static library. Can we stop providing
static library /usr/lib/libpci.a
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

ping?

pong, rawhide pciutils-2.2.9-3.fc9

Thanks.
APPROVED

Reverting part of it. (In reply to comment #6)
> 2) Do pciutils really need to install static library. Can we stop providing
> static library /usr/lib/libpci.a

For future reference, 'repoquery --whatrequires pciutils-devel --repoid
development-source --archlist src' would answer this. library put back in rawhide.