Bug 226237 - Merge Review: pcmciautils
Merge Review: pcmciautils
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 15:21 EST by Nobody's working on this, feel free to take it
Modified: 2007-12-06 07:45 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-12-06 07:45:43 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:21:42 EST
Fedora Merge Review: pcmciautils

Initial Owner: harald@redhat.com
Comment 1 Ville Skyttä 2007-03-03 07:13:52 EST
Doesn't use $RPM_OPT_FLAGS.  A simple fix is to do 'make
OPTIMIZATION="$RPM_OPT_FLAGS"' instead of 'make' in %build but that trumps the
upstream -Os vs -O2 selection.  Not a big deal, I think, but if there's a
compelling reason to use -Os, pcmciautils-fedora.patch could be changed to do
this in order to preserve it:

URL tag missing, a suitable one could be eg.

Are the pcmcia-cs and kernel-pcmcia-cs Obsoletes still needed?  If no, drop; if
yes, should be made versioned.

No PCMCIA hardware here so I'll leave rest of the review to someone else.
Comment 2 Harald Hoyer 2007-03-23 09:30:31 EDT
done... please check pcmciautils-014-6.fc7
Comment 3 Ville Skyttä 2007-03-23 13:35:21 EDT
(In reply to comment #2)
> done... please check pcmciautils-014-6.fc7

The changes look good to me, but as said in comment 1: "No PCMCIA hardware here
so I'll leave rest of the review to someone else."
Comment 4 Mamoru TASAKA 2007-03-28 20:51:44 EDT
pcmciautils-014-6.fc7 complains:

[root@localhost i386]# LANG=C rpm -Fvh --test pcmciautils-014-6.fc7.i386.rpm 
error: Failed dependencies:
        pcmcia-cs conflicts with hwdata-0.199-1.fc7.noarch
Comment 5 Parag AN(पराग) 2007-11-30 06:48:21 EST
rpmlint gave
pcmciautils.i386: W: obsolete-not-provided pcmcia-cs
pcmciautils.i386: W: obsolete-not-provided kernel-pcmcia-cs

you SHOULD use
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
to preserve timestamps.

Rest looks ok.
Comment 6 Parag AN(पराग) 2007-11-30 06:54:00 EST

Note You need to log in before you can comment on or make changes to this bug.