Red Hat Bugzilla – Bug 226237
Merge Review: pcmciautils
Last modified: 2007-12-06 07:45:43 EST
Fedora Merge Review: pcmciautils http://cvs.fedora.redhat.com/viewcvs/devel/pcmciautils/ Initial Owner: harald@redhat.com
Doesn't use $RPM_OPT_FLAGS. A simple fix is to do 'make OPTIMIZATION="$RPM_OPT_FLAGS"' instead of 'make' in %build but that trumps the upstream -Os vs -O2 selection. Not a big deal, I think, but if there's a compelling reason to use -Os, pcmciautils-fedora.patch could be changed to do this in order to preserve it: CFLAGS += $(RPM_OPT_FLAGS) $(OPTIMIZATION) -D_GNU_SOURCE URL tag missing, a suitable one could be eg. http://www.kernel.org/pub/linux/utils/kernel/pcmcia/pcmcia.html Are the pcmcia-cs and kernel-pcmcia-cs Obsoletes still needed? If no, drop; if yes, should be made versioned. No PCMCIA hardware here so I'll leave rest of the review to someone else.
done... please check pcmciautils-014-6.fc7
(In reply to comment #2) > done... please check pcmciautils-014-6.fc7 The changes look good to me, but as said in comment 1: "No PCMCIA hardware here so I'll leave rest of the review to someone else."
pcmciautils-014-6.fc7 complains: -------------------------------------- [root@localhost i386]# LANG=C rpm -Fvh --test pcmciautils-014-6.fc7.i386.rpm error: Failed dependencies: pcmcia-cs conflicts with hwdata-0.199-1.fc7.noarch --------------------------------------
rpmlint gave pcmciautils.i386: W: obsolete-not-provided pcmcia-cs pcmciautils.i386: W: obsolete-not-provided kernel-pcmcia-cs you SHOULD use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" to preserve timestamps. Rest looks ok.
APPROVED.