Bug 226238 - Merge Review: pcre
Summary: Merge Review: pcre
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: F9MergeReviewTarget
TreeView+ depends on / blocked
 
Reported: 2007-01-31 20:21 UTC by Nobody's working on this, feel free to take it
Modified: 2008-01-23 17:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-01-23 17:03:57 UTC
Type: ---
Embargoed:
gwync: fedora-review+

Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 20:21:48 UTC 
Fedora Merge Review: pcre

http://cvs.fedora.redhat.com/viewcvs/devel/pcre/
Initial Owner: than
Comment 1 Gwyn Ciesla 2008-01-23 14:41:18 UTC 
rpmlint: 
pcre.src:11: W: prereq-use /sbin/ldconfig
Can be resolved by replacing with BuildRequires: glibc

pcre.src:12: W: buildprereq-use sed
Can be dropped, it's in the Exceptions list.

Tested these changes in mock/rawhide, and it works.

Other than that, no blockers.
Comment 2 Ville Skyttä 2008-01-23 15:47:04 UTC 
(In reply to comment #1)
> rpmlint: 
> pcre.src:11: W: prereq-use /sbin/ldconfig
> Can be resolved by replacing with BuildRequires: glibc

Nope, that's not what it means.  See "rpmlint -I prereq-use".

Anyway, these issues and some others have been fixed in CVS a couple of months
ago: http://cvs.fedora.redhat.com/viewcvs/devel/pcre/pcre.spec?r1=1.25&r2=1.26
Comment 3 Gwyn Ciesla 2008-01-23 17:03:57 UTC 
So they have. Looks great now.

That'll teach me to review the latest koji build and not double-check cvs. :)

APPROVED.
Note You need to log in before you can comment on or make changes to this bug.