Bug 2262454 - Review Request: obs-service-go_modules - An OBS Service for vendoring go modules
Summary: Review Request: obs-service-go_modules - An OBS Service for vendoring go modules
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-02 22:13 UTC by Dan Čermák
Modified: 2025-05-26 20:46 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-05-26 20:46:08 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Dan Čermák 2024-02-02 22:13:32 UTC 
Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/defolos/devel/obs-service-go_modules.git/plain/obs-service-go_modules.spec?id=e11d1c07aa8c2cde668a0697238a6bfbfd17a644
SRPM URL: https://download.copr.fedorainfracloud.org/results/defolos/devel/fedora-39-x86_64/06982702-obs-service-go_modules/obs-service-go_modules-0.6.4-1.fc39.noarch.rpm
Description: An OBS Source Service that will download,
verify and vendor Go module dependency sources.
Fedora Account System Username: defolos

Build in COPR: https://copr.fedorainfracloud.org/coprs/defolos/devel/build/6982702/
Comment 1 Neal Gompa 2024-02-03 00:07:14 UTC 
Taking this review.
Comment 2 Dan Čermák 2024-02-12 10:53:55 UTC 
Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/defolos/devel/obs-service-go_modules.git/plain/obs-service-go_modules.spec?id=e11d1c07aa8c2cde668a0697238a6bfbfd17a644
SRPM URL: https://download.copr.fedorainfracloud.org/results/defolos/devel/fedora-39-x86_64/06982702-obs-service-go_modules/obs-service-go_modules-0.6.4-1.fc39.noarch.rpm


(the srpm url was accidentally the rpm url)
Comment 3 Neal Gompa 2024-02-23 11:22:50 UTC 
Initial spec review:

> Source:         %{URL}/archive/refs/tags/v%{version}.tar.gz#./%{name}-%{version}.tar.gz

This should be "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"

> %build

Please put a comment to indicate there's nothing to build (so it's clear that it's intentionally empty)
Comment 4 Dan Čermák 2024-07-26 08:58:16 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/defolos/devel/fedora-40-x86_64/07792725-obs-service-go_modules/obs-service-go_modules.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/defolos/devel/fedora-40-x86_64/07792725-obs-service-go_modules/obs-service-go_modules-0.6.4-2.fc40.src.rpm

Fixed both
Comment 5 Dan Čermák 2025-05-22 11:38:41 UTC 
New upstream release:

Spec URL: https://download.copr.fedorainfracloud.org/results/defolos/devel/fedora-rawhide-x86_64/09071665-obs-service-go_modules/obs-service-go_modules.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/defolos/devel/fedora-rawhide-x86_64/09071665-obs-service-go_modules/obs-service-go_modules-0.6.8-1.fc43.src.rpm

Can you please take a look Neal?
Comment 6 Neal Gompa 2025-05-22 12:44:42 UTC 
Review notes:

* Package follows Fedora Package Guidelines
* Package builds and installs
* Package licensing is correct and valid

PACKAGE APPROVED.
Comment 7 Fedora Admin user for bugzilla script actions 2025-05-23 19:34:44 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/obs-service-go_modules
Comment 8 Dan Čermák 2025-05-26 20:38:04 UTC 
https://pagure.io/releng/fedora-scm-requests/issue/76312
https://pagure.io/releng/fedora-scm-requests/issue/76313
Comment 9 Dan Čermák 2025-05-26 20:46:08 UTC 
Built in Rawhide
Note You need to log in before you can comment on or make changes to this bug.