Red Hat Bugzilla – Bug 226246
Merge Review: perl-Compress-Zlib
Last modified: 2007-11-30 17:11:55 EST
Fedora Merge Review: perl-Compress-Zlib
Initial Owner: email@example.com
The big database in the sky is still confused about this one.
Initial owner: firstname.lastname@example.org
Joe - You're welcome to have it, if you want it. :-)
Update to Compress::Zlib 2.00x
According to the requirements list of Compress::Zlib 2 the following modules
will have to be packaged:
* http://search.cpan.org/dist/IO-Compress-Base/ (review ticket #228537)
1)perl as BR is not needed. mock build without it worked successfully.
remove redundant dependency on perl
Removed BR, and built 2.005-3
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
All tests successful.
Files=8, Tests=726, 2 wallclock secs ( 2.15 cusr + 0.31 csys = 2.46 CPU)
+ Package perl-Compress-Zlib-2.005-3.fc8->
Provides: perl(Compress::Zlib) = 2.005 perl(Zlib::OldDeflate)
Requires: perl >= 0:5.004 perl(AutoLoader) perl(Carp)
perl(Compress::Raw::Zlib) >= 2.005 perl(Exporter)
perl(IO::Compress::Base::Common) >= 2.005 perl(IO::Compress::Gzip) >= 2.005
perl(IO::Compress::Gzip::Constants) >= 2.005 perl(IO::Handle)
perl(IO::Uncompress::Gunzip) >= 2.005 perl(Scalar::Util) perl(bytes)
perl(constant) perl(strict) perl(warnings)
As reviewed package is in CVS, you can CLOSE this review.
Can we CLOSE this review if package is already built and in rawhide?