Bug 226246 - Merge Review: perl-Compress-Zlib
Merge Review: perl-Compress-Zlib
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On: 228537
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:34 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-11-12 05:33:22 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:34:19 EST
Fedora Merge Review: perl-Compress-Zlib

http://cvs.fedora.redhat.com/viewcvs/devel/perl-Compress-Zlib/
Initial Owner: jorton@redhat.com
Comment 1 Joe Orton 2007-01-31 17:13:07 EST
The big database in the sky is still confused about this one.

Initial owner: rnorwood@redhat.com
Comment 2 Robin Norwood 2007-02-04 15:56:43 EST
Joe - You're welcome to have it, if you want it. :-)
Comment 3 Jose Pedro Oliveira 2007-02-18 17:36:43 EST
Update to Compress::Zlib 2.00x
------------------------------

According to the requirements list of Compress::Zlib 2 the following modules
will have to be packaged:

 * http://search.cpan.org/dist/IO-Compress-Base/  (review ticket #228537)
 * http://search.cpan.org/dist/IO-Compress-Zlib/
 * http://search.cpan.org/dist/Compress-Raw-Zlib/

jpo
Comment 4 Parag AN(पराग) 2007-10-22 06:50:22 EDT
1)perl as BR is not needed. mock build without it worked successfully.
   remove redundant dependency on perl 
Comment 5 Robin Norwood 2007-10-23 16:08:37 EDT
Removed BR, and built 2.005-3
Comment 6 Parag AN(पराग) 2007-10-24 00:19:25 EDT
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2eb448ae8ec536f4b6744882f02819d3  Compress-Zlib-2.005.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs 
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/000prereq.....ok
t/01version.....ok
t/03zlib-v1.....ok
t/05examples....ok
t/06gzsetp......ok
t/08encoding....ok
t/14gzopen......ok
t/99pod.........ok
All tests successful.
Files=8, Tests=726,  2 wallclock secs ( 2.15 cusr +  0.31 csys =  2.46 CPU)
+ Package  perl-Compress-Zlib-2.005-3.fc8->
  Provides: perl(Compress::Zlib) = 2.005 perl(Zlib::OldDeflate)
perl(Zlib::OldInflate)
  Requires: perl >= 0:5.004 perl(AutoLoader) perl(Carp)
perl(Compress::Raw::Zlib) >= 2.005 perl(Exporter)
perl(IO::Compress::Base::Common) >= 2.005 perl(IO::Compress::Gzip) >= 2.005
perl(IO::Compress::Gzip::Constants) >= 2.005 perl(IO::Handle)
perl(IO::Uncompress::Gunzip) >= 2.005 perl(Scalar::Util) perl(bytes)
perl(constant) perl(strict) perl(warnings)

APPROVED.


As reviewed package is in CVS, you can CLOSE this review.
Comment 7 Parag AN(पराग) 2007-11-11 02:04:20 EST
Can we CLOSE this review if package is already built and in rawhide?

Note You need to log in before you can comment on or make changes to this bug.