Fedora Merge Review: perl-DBD-MySQL http://cvs.fedora.redhat.com/viewcvs/devel/perl-DBD-MySQL/ Initial Owner: rnorwood
1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 1:5.6.1 2)you may like to use disttag like only "2%{?dist}" 3)rpmlint only complained -> perl-DBD-MySQL.i386: W: file-not-utf8 /usr/share/doc/perl-DBD-MySQL-4.005/ChangeLog The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). ==> Use iconv
iconv warning can be solve by adding following to %prep section file=ChangeLog iconv -f iso-8859-1 -t utf-8 < "$file" > "${file}_" mv -f "${file}_" "$file"
Review based on current CVS trunk Review: + package builds in mock (development i386). + rpmlint is silent for SRPM But not for RPM. perl-DBD-MySQL.i386: W: file-not-utf8 /usr/share/doc/perl-DBD-MySQL-4.005/ChangeLog ==> can be solved as given in comment #2 + source files match upstream url 39181a061348ad76b67c99326873ccd5 DBD-mysql-4.005.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs + Package perl-DBD-MySQL-4.005-3.fc8 -> Provides: mysql.so perl(Bundle::DBD::mysql) = 4.004 perl(DBD::mysql) = 4.005 perl(DBD::mysql::GetInfo) perl(DBD::mysql::db) perl(DBD::mysql::dr) perl(DBD::mysql::st) perl-DBD-mysql = 4.005-3.fc8 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcrypt.so.1 libcrypto.so.6 libm.so.6 libmysqlclient.so.15 libmysqlclient.so.15(libmysqlclient_15) libnsl.so.1 libssl.so.6 libz.so.1 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(DBD::mysql) perl(DBI) perl(DBI::Const::GetInfoType) perl(DynaLoader) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED.
you can close this review once you finish iconv change in CVS and build the package.
perl-DBD-MySQL-4.005-4.fc9 built in dist-f9