Spec URL: https://alebastr.fedorapeople.org/sway-contrib.spec SRPM URL: https://alebastr.fedorapeople.org/sway-contrib-1.9~rc2-1.fc39.src.rpm Description: Collection of user-contributed scripts for Sway. Fedora Account System Username: alebastr
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=112883602
Copr build: https://copr.fedorainfracloud.org/coprs/build/6983940 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262536-sway-contrib/fedora-rawhide-x86_64/06983940-sway-contrib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Would be great to resolve these two RPM build issues: *** WARNING: ./usr/libexec/sway-contrib/firefox-focus-monitor.py is executable but has no shebang, removing executable bit mangling shebang in /usr/bin/grimshot from /bin/sh to #!/usr/bin/sh
Spec URL: https://alebastr.fedorapeople.org/sway-contrib.spec SRPM URL: https://alebastr.fedorapeople.org/sway-contrib-1.9~rc2-1.fc39.src.rpm > *** WARNING: ./usr/libexec/sway-contrib/firefox-focus-monitor.py is executable but has no shebang, removing executable bit Fixed by preserving the permissions of the scripts drwxr-xr-x 2 root root 0 Feb 3 16:00 /usr/libexec/sway-contrib -rwxr-xr-x 1 root root 3533 Jan 20 08:58 /usr/libexec/sway-contrib/autoname-workspaces.py -rw-r--r-- 1 root root 4048 Jan 20 08:58 /usr/libexec/sway-contrib/firefox-focus-monitor.py -rwxr-xr-x 1 root root 2014 Jan 20 08:58 /usr/libexec/sway-contrib/inactive-windows-transparency.py -rwxr-xr-x 1 root root 1527 Jan 20 08:58 /usr/libexec/sway-contrib/layout-per-window.py -rwxr-xr-x 1 root root 3129 Jan 20 08:58 /usr/libexec/sway-contrib/switch-top-level.py drwxr-xr-x 2 root root 0 Feb 3 16:00 /usr/share/licenses/sway-contrib -rw-r--r-- 1 root root 1057 Jan 20 08:58 /usr/share/licenses/sway-contrib/LICENSE I'll try to send a fix upstream before the final release. > mangling shebang in /usr/bin/grimshot from /bin/sh to #!/usr/bin/sh That's not an error, /usr/bin/sh is specific to (most of) systemd distributions and will be incorrect on other systems: <alebastr@freebsd-dev-64:~> zsh/2 288 % ls /usr/bin/sh ls: /usr/bin/sh: No such file or directory
I agree with the explanation. Thank you! I don't see any other issue. ACKing this review.
The Pagure repository was created at https://src.fedoraproject.org/rpms/sway-contrib
FEDORA-2024-030bda6025 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-030bda6025
FEDORA-2024-030bda6025 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.