Hide Forgot
Fedora Merge Review: perl-HTML-Tagset http://cvs.fedora.redhat.com/viewcvs/devel/perl-HTML-Tagset/ Initial Owner: rnorwood@redhat.com
Created attachment 147287 [details] Specfile patch Robin, The patch corrects a couple of minor issues: * corrects the previous changelog entry * changes the order of the find options * expands tabs to spaces jpo
Robin, Please also add perl(Test::Pod) to the build requirements: ---------- BuildArch: noarch +BuildRequires: perl(Test::Pod) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) ---------- jpo
Alright, changes have been made, new RPM built....Thanks, Jose, let me know how it looks.
Robin, Did the package build correctly with the Test::Pod build requirement? (I'm not sure if the build system is able to pull packages from Extras.) jpo
Nope - it did not - I spoke to soon in comment #3 I've gotta go catch a plane - I'll look at it monday. Thanks again for the review.
(In reply to comment #5) > Nope - it did not - I spoke to soon in comment #3 :( > I've gotta go catch a plane - I'll look at it monday. Boa viagem! ;)
ok - now perl-HTML-Tagset-3.10-5.fc7 should be good to go. How about we fight about getting perl-Test-Pod into the buildroots *after* the core/extras consolidation? Thanks, -RN (And it was a good trip for me, thanks. My luggage is a little late, but at least I got home.)
Hey Jose - when you get a chance, please give the new perl-HTML-Tagset a looksee and approve it if it looks good.
Sorry for the omission. Package approved. jpo
Closing... (merge review with fedora-review+)