Bug 226261 - Merge Review: perl-HTML-Tagset
Merge Review: perl-HTML-Tagset
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Robin Norwood
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:35 EST by Nobody's working on this, feel free to take it
Modified: 2009-02-26 18:40 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-26 18:40:01 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jose.p.oliveira.oss: fedora‑review+


Attachments (Terms of Use)
Specfile patch (2.28 KB, patch)
2007-02-03 17:50 EST, Jose Pedro Oliveira
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:35:53 EST
Fedora Merge Review: perl-HTML-Tagset

http://cvs.fedora.redhat.com/viewcvs/devel/perl-HTML-Tagset/
Initial Owner: rnorwood@redhat.com
Comment 1 Jose Pedro Oliveira 2007-02-03 17:50:24 EST
Created attachment 147287 [details]
Specfile patch

Robin,

The patch corrects a couple of minor issues:
 * corrects the previous changelog entry
 * changes the order of the find options
 * expands tabs to spaces

jpo
Comment 2 Jose Pedro Oliveira 2007-02-03 18:04:37 EST
Robin,

Please also add perl(Test::Pod) to the build requirements:

----------
 BuildArch:      noarch
+BuildRequires:  perl(Test::Pod)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
----------

jpo
Comment 3 Robin Norwood 2007-02-04 16:30:11 EST
Alright, changes have been made, new RPM built....Thanks, Jose, let me know how
it looks.
Comment 4 Jose Pedro Oliveira 2007-02-04 16:35:11 EST
Robin,

Did the package build correctly with the Test::Pod build requirement?
(I'm not sure if the build system is able to pull packages from Extras.)

jpo
Comment 5 Robin Norwood 2007-02-04 16:37:11 EST
Nope - it did not - I spoke to soon in comment #3

I've gotta go catch a plane - I'll look at it monday.

Thanks again for the review.
Comment 6 Jose Pedro Oliveira 2007-02-04 16:45:47 EST
(In reply to comment #5)
> Nope - it did not - I spoke to soon in comment #3

:(
 
> I've gotta go catch a plane - I'll look at it monday.

Boa viagem!
;)

Comment 7 Robin Norwood 2007-02-05 11:24:23 EST
ok - now perl-HTML-Tagset-3.10-5.fc7 should be good to go.  How about we fight
about getting perl-Test-Pod into the buildroots *after* the core/extras
consolidation?

Thanks,

-RN

(And it was a good trip for me, thanks.  My luggage is a little late, but at
least I got home.)
Comment 8 Robin Norwood 2007-02-17 22:10:35 EST
Hey Jose - when you get a chance, please give the new perl-HTML-Tagset a looksee
and approve it if it looks good.
Comment 9 Jose Pedro Oliveira 2007-02-18 10:39:49 EST
Sorry for the omission.
Package approved.

jpo
Comment 10 Chris Weyl 2009-02-26 18:40:01 EST
Closing... (merge review with fedora-review+)

Note You need to log in before you can comment on or make changes to this bug.