Bug 226265 - Merge Review: perl-IO-String
Merge Review: perl-IO-String
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:36 EST by Nobody's working on this, feel free to take it
Modified: 2007-12-21 14:42 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-11-12 05:36:22 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:36:25 EST
Fedora Merge Review: perl-IO-String

http://cvs.fedora.redhat.com/viewcvs/devel/perl-IO-String/
Initial Owner: rnorwood@redhat.com
Comment 1 Parag AN(पराग) 2007-10-26 06:42:45 EDT
1)perl as BR is not needed. mock build without it worked successfully.
   remove redundant dependency on perl >= 1:5.6.1
2)drop "|| :" from %check
3)you may like to add disttag 
4) don't hard code version in Source URL
4)rpmlint only complained ->
perl-IO-String.noarch: W: incoherent-version-in-changelog 0:1.08-2 1.08-2
Comment 2 Robin Norwood 2007-10-26 15:58:03 EDT
All issues should be fixed in new version: perl-IO-String-1.08.4.fc9
Comment 3 Parag AN(पराग) 2007-10-26 22:04:43 EDT
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
250e5424f290299fc3d6b5d1e9da3835  IO-String-1.08.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/close.......ok
t/para........ok
t/read........ok
t/seek........ok
t/truncate....ok
t/write.......ok
All tests successful.
Files=6, Tests=43,  0 wallclock secs ( 0.09 cusr +  0.04 csys =  0.13 CPU)
+ Package perl-IO-String-1.08-3.fc8 ->
   Provides: perl(IO::String) = 1.08Requires: perl >= 0:5.005_03
perl(:MODULE_COMPAT_5.8.8) perl(Symbol) perl(strict) perl(vars)

APPROVED.
   
Comment 4 Parag AN(पराग) 2007-11-11 02:04:10 EST
Can we CLOSE this review if package is already built and in rawhide?
Comment 5 Steven Pritchard 2007-12-21 13:17:06 EST
This package is required by perl-Archive-Tar in EPEL 4.

Package Change Request
======================
Package Name: perl-IO-String
New Branches: EL-4
Updated EPEL Owners: steve,rnorwood
Comment 6 Kevin Fenzi 2007-12-21 14:42:22 EST
cvs done.

Note You need to log in before you can comment on or make changes to this bug.