Red Hat Bugzilla – Bug 226265
Merge Review: perl-IO-String
Last modified: 2007-12-21 14:42:22 EST
Fedora Merge Review: perl-IO-String
Initial Owner: firstname.lastname@example.org
1)perl as BR is not needed. mock build without it worked successfully.
remove redundant dependency on perl >= 1:5.6.1
2)drop "|| :" from %check
3)you may like to add disttag
4) don't hard code version in Source URL
4)rpmlint only complained ->
perl-IO-String.noarch: W: incoherent-version-in-changelog 0:1.08-2 1.08-2
All issues should be fixed in new version: perl-IO-String-1.08.4.fc9
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
All tests successful.
Files=6, Tests=43, 0 wallclock secs ( 0.09 cusr + 0.04 csys = 0.13 CPU)
+ Package perl-IO-String-1.08-3.fc8 ->
Provides: perl(IO::String) = 1.08Requires: perl >= 0:5.005_03
perl(:MODULE_COMPAT_5.8.8) perl(Symbol) perl(strict) perl(vars)
Can we CLOSE this review if package is already built and in rawhide?
This package is required by perl-Archive-Tar in EPEL 4.
Package Change Request
Package Name: perl-IO-String
New Branches: EL-4
Updated EPEL Owners: steve,rnorwood