Bug 226267 (perl-LDAP) - Merge Review: perl-LDAP
Summary: Merge Review: perl-LDAP
Status: CLOSED NEXTRELEASE
Alias: perl-LDAP
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All Linux
medium
medium
Target Milestone: ---
Assignee: Robin Norwood
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-31 20:36 UTC by Nobody's working on this, feel free to take it
Modified: 2012-11-26 13:07 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-21 20:42:03 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jochen: fedora-review+


Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 20:36:31 UTC
Fedora Merge Review: perl-LDAP

http://cvs.fedora.redhat.com/viewcvs/devel/perl-LDAP/
Initial Owner: rnorwood@redhat.com

Comment 1 Jochen Schmitt 2007-04-03 16:26:05 UTC
Good:
+ Tar ball matches with upstream.
+ Rpmlint ok for source package.
+ Local build works fine.

Bad:
- Rpmlint complaint binary rpm:
rpmlint perl-LDAP-0.34-1.noarch.rpm
E: perl-LDAP useless-explicit-provides perl(Net::LDAP::Filter)






Comment 2 Robin Norwood 2007-04-05 17:03:54 UTC
Ok - filtering out the provides for perl(Net::LDAP::Filter) in the usual way.

(http://fedoraproject.org/wiki/Packaging/Perl)

Comment 3 Robin Norwood 2007-04-10 14:17:18 UTC
oops - turns out when I actually looked at it that the problem with the provides
was that there is a versioned "Provides: perl(Net::LDAP::Filter) = 15", and and
unversioned "Provides: perl(Net::LDAP::Filter)".  So, the filter had to be
changed to only filter out the 'unversioned' one.

Comment 4 Jochen Schmitt 2007-06-21 18:13:57 UTC
Ping morwood@redhat.com

Comment 5 Jochen Schmitt 2007-06-21 18:23:55 UTC
Good:
+ Rpmlint quite on binary package.
+ Filelist seems ok.
+ Local install and uninstall works fine.
+ Mock build works fine.
+ License seems ok.

Bad.
- Package should not used Epoch Tag. (No blocker, becouse changing it may breaks
EVR path)

*** APPROVED ***



Comment 6 Robin Norwood 2007-06-21 19:23:23 UTC
Thanks for the review.



Comment 7 Jochen Schmitt 2007-06-21 20:42:03 UTC
I think, is ok, when I close this bug.

Comment 8 Petr Pisar 2012-11-26 09:30:52 UTC
Package Change Request
======================
Package Name: perl-LDAP
Branches: f16 f17 f18
Owners: 
InitialCC: perl-sig

Please add pseudo-user `perl-sig' with watch* permission only to all Fedora branches.

Comment 9 Gwyn Ciesla 2012-11-26 13:03:58 UTC
Done.


Note You need to log in before you can comment on or make changes to this bug.