Fedora Merge Review: perl-LDAP http://cvs.fedora.redhat.com/viewcvs/devel/perl-LDAP/ Initial Owner: rnorwood
Good: + Tar ball matches with upstream. + Rpmlint ok for source package. + Local build works fine. Bad: - Rpmlint complaint binary rpm: rpmlint perl-LDAP-0.34-1.noarch.rpm E: perl-LDAP useless-explicit-provides perl(Net::LDAP::Filter)
Ok - filtering out the provides for perl(Net::LDAP::Filter) in the usual way. (http://fedoraproject.org/wiki/Packaging/Perl)
oops - turns out when I actually looked at it that the problem with the provides was that there is a versioned "Provides: perl(Net::LDAP::Filter) = 15", and and unversioned "Provides: perl(Net::LDAP::Filter)". So, the filter had to be changed to only filter out the 'unversioned' one.
Ping morwood
Good: + Rpmlint quite on binary package. + Filelist seems ok. + Local install and uninstall works fine. + Mock build works fine. + License seems ok. Bad. - Package should not used Epoch Tag. (No blocker, becouse changing it may breaks EVR path) *** APPROVED ***
Thanks for the review.
I think, is ok, when I close this bug.
Package Change Request ====================== Package Name: perl-LDAP Branches: f16 f17 f18 Owners: InitialCC: perl-sig Please add pseudo-user `perl-sig' with watch* permission only to all Fedora branches.
Done.