Fedora Merge Review: perl-libwww-perl http://cvs.fedora.redhat.com/viewcvs/devel/perl-libwww-perl/ Initial Owner: rnorwood
1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 1:5.6.1 2)rpmlint complained -> perl-libwww-perl.noarch: W: file-not-utf8 /usr/share/doc/perl-libwww-perl-5.808/AUTHORS The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). perl-libwww-perl.noarch: W: file-not-utf8 /usr/share/doc/perl-libwww-perl-5.808/README The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). perl-libwww-perl.noarch: W: file-not-utf8 /usr/share/doc/perl-libwww-perl-5.808/Changes The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). perl-libwww-perl.src: I: checking perl-libwww-perl.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 16) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. 3) make test skipped some tests but I guess they are ok. Do you think it can be solved?
1, 2) fixed 3) I don't really know enough about the module to fix them. I looked at them a few months ago, and couldn't figure out why they were failing in mock but not on my system. New version: perl-libwww-perl-5.808-4.fc9
(In reply to comment #2) > 3) I don't really know enough about the module to fix them. I looked at them a > few months ago, and couldn't figure out why they were failing in mock but not on > my system. You didn't in fact look, did you? ;) It's this: bug #487620, nothing that would block this review.