Bug 226268 - Merge Review: perl-libwww-perl
Merge Review: perl-libwww-perl
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:36 EST by Nobody's working on this, feel free to take it
Modified: 2009-02-26 21:56 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-26 21:56:09 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lkundrak: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:36:35 EST
Fedora Merge Review: perl-libwww-perl

http://cvs.fedora.redhat.com/viewcvs/devel/perl-libwww-perl/
Initial Owner: rnorwood@redhat.com
Comment 1 Parag AN(पराग) 2007-10-26 06:47:59 EDT
1)perl as BR is not needed. mock build without it worked successfully.
   remove redundant dependency on perl >= 1:5.6.1
2)rpmlint complained ->
perl-libwww-perl.noarch: W: file-not-utf8
/usr/share/doc/perl-libwww-perl-5.808/AUTHORS
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

perl-libwww-perl.noarch: W: file-not-utf8
/usr/share/doc/perl-libwww-perl-5.808/README
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

perl-libwww-perl.noarch: W: file-not-utf8
/usr/share/doc/perl-libwww-perl-5.808/Changes
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

perl-libwww-perl.src: I: checking
perl-libwww-perl.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 16)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

3) make test skipped some tests but I guess they are ok. Do you think it can be
solved?
Comment 2 Robin Norwood 2007-10-26 15:52:58 EDT
1, 2) fixed

3) I don't really know enough about the module to fix them.  I looked at them a
few months ago, and couldn't figure out why they were failing in mock but not on
my system.

New version: perl-libwww-perl-5.808-4.fc9
Comment 3 Lubomir Rintel 2009-02-26 21:56:09 EST
(In reply to comment #2)
> 3) I don't really know enough about the module to fix them.  I looked at them a
> few months ago, and couldn't figure out why they were failing in mock but not on
> my system.

You didn't in fact look, did you? ;)
It's this: bug #487620, nothing that would block this review.

Note You need to log in before you can comment on or make changes to this bug.