Fedora Merge Review: perl-Net-SSLeay http://cvs.fedora.redhat.com/viewcvs/devel/perl-Net-SSLeay/ Initial Owner: wtogami
1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl 2)you may like to keep simple disttag as "5%{dist}" only.
Warren, Can you please update SPEC and build package?
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url b0cd6c1681bbc0695d81be5cd852d1d0 Net_SSLeay.pm-1.30.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package perl-Net-SSLeay-1.30-7.fc9 -> Provides: SSLeay.so perl(Net::SSLeay) = 1.30 perl(Net::SSLeay::Handle) = 0.61 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libcrypto.so.6 libssl.so.6 perl >= 0:5.005_03 perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(DynaLoader) perl(Errno) perl(Exporter) perl(Net::SSLeay) perl(Socket) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED.